ADFA-5586 | Markdown Previewer: explain empty Project picks and render JS-driven HTML (#105)

fix(ADFA-5586): report empty Project picks and run page scripts in the previewer

Project returned silently when no project was open or no file matched,
and the only HTML in a fresh project (Gradle's problems report) lives
under build/, which the picker skips. Show a dialog for both cases.
Walk the project off the main thread and prune build/ and hidden
directories instead of walking them and filtering afterwards.

The problems report renders with JavaScript; with JS disabled its static
"Loading..." body never changed. Enable JS, with file and content access
disabled.

Co-authored-by: Daniel Alome <astrocoder007@gmail.com>

Author: Daniel-ADFA

plugins/Markdown-Previewer/src/main/kotlin/org/appdevforall/markdownpreviewer/fragments/MarkdownPreviewFragment.kt

@@ -31,7 +31,9 @@ import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.itsaky.androidide.plugins.base.PluginFragmentHelper
 import com.itsaky.androidide.plugins.services.IdeFileService
 import com.itsaky.androidide.plugins.services.IdeProjectService
+import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import java.io.File
 
 class MarkdownPreviewFragment : Fragment() {
@@ -145,7 +147,9 @@ class MarkdownPreviewFragment : Fragment() {
 
     private fun setupWebView() {
         webView.settings.apply {
-            javaScriptEnabled = false
+            javaScriptEnabled = true
+            allowFileAccess = false
+            allowContentAccess = false
             loadWithOverviewMode = true
             useWideViewPort = true
             builtInZoomControls = true
@@ -238,22 +242,35 @@ class MarkdownPreviewFragment : Fragment() {
     }
 
     private fun showProjectFilePicker() {
-        val project = projectService?.getCurrentProject() ?: return
+        val project = projectService?.getCurrentProject()
+        if (project == null) {
+            showMessage(R.string.no_project)
+            return
+        }
+        val rootDir = project.rootDir
         viewLifecycleOwner.lifecycleScope.launch {
-            val files = findSupportedFiles(project.rootDir)
-            if (files.isEmpty()) return@launch
-            showFileSelectionDialog(files, project.rootDir)
+            val files = withContext(Dispatchers.IO) { findSupportedFiles(rootDir) }
+            if (files.isEmpty()) showMessage(R.string.no_files_found)
+            else showFileSelectionDialog(files, rootDir)
         }
     }
 
     private fun findSupportedFiles(rootDir: File): List<File> {
         return rootDir.walkTopDown()
+            .onEnter { it == rootDir || (it.name != "build" && !it.name.startsWith(".")) }
             .filter { it.isFile && MarkdownPreviewerPlugin.isSupportedFile(it) }
-            .filter { !it.absolutePath.contains("/build/") && !it.absolutePath.contains("/.") }
             .sortedBy { it.name.lowercase() }
             .toList()
     }
 
+    private fun showMessage(messageRes: Int) {
+        MaterialAlertDialogBuilder(requireContext())
+            .setTitle(R.string.select_from_project)
+            .setMessage(messageRes)
+            .setPositiveButton(android.R.string.ok, null)
+            .show()
+    }
+
     private fun showFileSelectionDialog(files: List<File>, rootDir: File) {
         val fileNames = files.map { it.absolutePath.removePrefix(rootDir.absolutePath + "/") }.toTypedArray()
         MaterialAlertDialogBuilder(requireContext())

plugins/Markdown-Previewer/src/main/res/values/strings.xml

@@ -18,8 +18,8 @@
 
     <!-- Status Messages -->
     <string name="loading">Loading…</string>
-    <string name="no_project">No project available</string>
-    <string name="no_files_found">No supported files found</string>
+    <string name="no_project">No project is open. Open a project, or use Storage to pick a file.</string>
+    <string name="no_files_found">This project has no Markdown or HTML files. Files under build/ and hidden folders are skipped; use Storage to open one of those.</string>
     <string name="file_not_found">File not found</string>
     <string name="cannot_read_file">Cannot read file</string>