Skip to content

Commit af5c503

Browse files
committed
Removing resource limits for the controller container on the head pod
1 parent ca6a23f commit af5c503

File tree

1 file changed

+3
-29
lines changed

1 file changed

+3
-29
lines changed

axlearn/cloud/gcp/pathways_utils.py

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -135,14 +135,10 @@ class Config(BaseReplicatedJob.Config):
135135
136136
Attributes:
137137
inner: The wrapped TPUReplicatedJob configuration.
138-
pathways_head_cpu: CPU request for pathways-head container.
139-
pathways_head_mem: Memory request for pathways-head container.
140138
"""
141139

142140
inner: Required[TPUReplicatedJob.Config] = REQUIRED
143141
pathways_xla_flags: list[str] = []
144-
pathways_head_cpu: Optional[str] = None
145-
pathways_head_mem: Optional[str] = None
146142

147143
@classmethod
148144
def define_flags(cls, fv):
@@ -159,24 +155,6 @@ def define_flags(cls, fv):
159155
"Example: 'xla_tpu_x=24,megascale_y=true'",
160156
**common_kwargs,
161157
)
162-
flags.DEFINE_string(
163-
"pathways_head_cpu",
164-
None,
165-
"CPU request for pathways-head container in cores. Default is 1 core.",
166-
**common_kwargs,
167-
)
168-
flags.DEFINE_string(
169-
"pathways_head_mem",
170-
None,
171-
"Memory request for pathways-head container in GiB. Default is 16GiB",
172-
**common_kwargs,
173-
)
174-
175-
@classmethod
176-
def set_defaults(cls, fv):
177-
super().set_defaults(fv)
178-
fv.set_default("pathways_head_cpu", fv.pathways_head_cpu or "32")
179-
fv.set_default("pathways_head_mem", fv.pathways_head_mem or "128")
180158

181159
@classmethod
182160
def default_config(cls):
@@ -287,14 +265,10 @@ def _build_pathways_head_container(self) -> dict:
287265

288266
head_container["env"] = env_list
289267

290-
cpu_req = f"{float(self.config.pathways_head_cpu) * 1000}m"
291-
mem_req = f"{self.config.pathways_head_mem}Gi"
292-
resources = {
293-
"requests": {"cpu": cpu_req, "memory": mem_req},
294-
"limits": {"cpu": cpu_req, "memory": mem_req},
268+
head_container["resources"] = {
269+
"requests": {},
270+
"limits": {},
295271
}
296-
head_container["resources"] = resources
297-
298272
return head_container
299273

300274
def _build_pathways_head_sidecar_containers(self) -> list[Nested[Any]]:

0 commit comments

Comments
 (0)