From 7ea592819caaf1f836ec2cfdde7b1d1cbca4cf3a Mon Sep 17 00:00:00 2001 From: Gururaj Deshpande <66385690+guru-desh@users.noreply.github.com> Date: Tue, 12 Nov 2024 19:50:07 -0800 Subject: [PATCH 1/2] R** move cmake installation to env_create.sh --- scripts/build.sh | 3 --- scripts/env_create.sh | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/build.sh b/scripts/build.sh index 56998f8b0..bc311e987 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -107,9 +107,6 @@ CMAKE_COMMAND="" if [[ $OSTYPE == darwin* ]]; then CMAKE_COMMAND="xcrun --sdk ${sdk} " fi -if [ -z "`which cmake`" ] || [ "`which cmake`" = "cmake not found" ]; then - conda install cmake -y -fi CMAKE_COMMAND+="cmake $ADDITIONAL_CMAKE_OPTIONS \ -DCMAKE_BUILD_TYPE=$BUILD_MODE \ -DPYTHON_EXECUTABLE:FILEPATH=$PYTHON_EXECUTABLE \ diff --git a/scripts/env_create.sh b/scripts/env_create.sh index dc58e6254..5692c6cd9 100755 --- a/scripts/env_create.sh +++ b/scripts/env_create.sh @@ -110,6 +110,7 @@ if [[ $DEV == 1 ]]; then python -m pip install -e "$COREMLTOOLS_HOME/../coremltools" --upgrade fi +conda install -y cmake conda deactivate echo From f6bade51e2a219f24316f1129399b29e2c03fd13 Mon Sep 17 00:00:00 2001 From: Gururaj Deshpande <66385690+guru-desh@users.noreply.github.com> Date: Tue, 12 Nov 2024 19:52:03 -0800 Subject: [PATCH 2/2] d - remove cmake requirement from documentation --- BUILDING.md | 1 - docs-guides/source/installing-coremltools.md | 2 -- 2 files changed, 3 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index a3d35da3a..cd033d8fb 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -7,7 +7,6 @@ This page describes how to build Core ML Tools (coremltools) from the source rep To build coremltools from source, you need the following: -* [CMake](https://cmake.org/) * [Miniconda](https://docs.conda.io/en/latest/miniconda.html) (or [Anaconda](https://www.anaconda.com/)) * [Zsh shell](http://zsh.sourceforge.net/) (the default shell for macOS 10.16+) installed in /usr/bin * A C++17 compatible compiler (if using GCC, need GCC 9.0 or later) diff --git a/docs-guides/source/installing-coremltools.md b/docs-guides/source/installing-coremltools.md index ae7fb57a4..4cb4d224d 100644 --- a/docs-guides/source/installing-coremltools.md +++ b/docs-guides/source/installing-coremltools.md @@ -126,8 +126,6 @@ pip install coremltools-4.0-cp38-none-macosx_10_12_intel.whl ## Build From Source -To build Core ML Tools and its dependent libraries from source, you need to install [CMake](https://cmake.org/) to configure the project. - To perform the build, fork and clone the [`coremltools` repository](https://github.com/apple/coremltools) and run the [`build.sh`](https://github.com/apple/coremltools/blob/master/scripts/build.sh) script: ```shell