Skip to content

Commit d77b57a

Browse files
committed
fix: QA fixes
1 parent ce92c27 commit d77b57a

File tree

9 files changed

+81
-20
lines changed

9 files changed

+81
-20
lines changed

src/routes/(console)/project-[project]/functions/function-[function]/executions/(components)/LogsRequest.svelte

+22-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,17 @@
6767
</Layout.Stack>
6868
{#if requestTab === 'parameters'}
6969
{#if parameters?.length}
70-
<Table.Root columns={2} let:root>
70+
<Table.Root
71+
columns={[
72+
{
73+
id: 'key',
74+
width: 200
75+
},
76+
{
77+
id: 'value'
78+
}
79+
]}
80+
let:root>
7181
<svelte:fragment slot="header" let:root>
7282
<Table.Header.Cell {root}>Key</Table.Header.Cell>
7383
<Table.Header.Cell {root}>Value</Table.Header.Cell>
@@ -86,7 +96,17 @@
8696
{/if}
8797
{:else if requestTab === 'headers'}
8898
{#if selectedLog.requestHeaders?.length}
89-
<Table.Root columns={2} let:root>
99+
<Table.Root
100+
columns={[
101+
{
102+
id: 'key',
103+
width: 200
104+
},
105+
{
106+
id: 'value'
107+
}
108+
]}
109+
let:root>
90110
<svelte:fragment slot="header" let:root>
91111
<Table.Header.Cell {root}>Key</Table.Header.Cell>
92112
<Table.Header.Cell {root}>Value</Table.Header.Cell>

src/routes/(console)/project-[project]/functions/function-[function]/executions/(components)/LogsResponse.svelte

+11-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,17 @@
8181
{/if}
8282
{:else if responseTab === 'headers'}
8383
{#if selectedLog.responseHeaders?.length}
84-
<Table.Root columns={2} let:root>
84+
<Table.Root
85+
columns={[
86+
{
87+
id: 'key',
88+
width: 200
89+
},
90+
{
91+
id: 'value'
92+
}
93+
]}
94+
let:root>
8595
<svelte:fragment slot="header" let:root>
8696
<Table.Header.Cell {root}>Key</Table.Header.Cell>
8797
<Table.Header.Cell {root}>Value</Table.Header.Cell>

src/routes/(console)/project-[project]/functions/function-[function]/executions/store.ts

+9-8
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import type { Column } from '$lib/helpers/types';
22
import { writable } from 'svelte/store';
33

44
export const columns = writable<Column[]>([
5-
{ id: '$id', title: 'Execution ID', type: 'string', width: 200 },
5+
{ id: '$id', title: 'Execution ID', type: 'string', width: { min: 200, max: 250 } },
66
{
77
id: 'requestPath',
88
title: 'Path',
99
type: 'string',
10-
width: 90,
10+
width: { min: 100, max: 200 },
1111
format: 'string'
1212
},
1313

@@ -16,7 +16,7 @@ export const columns = writable<Column[]>([
1616
title: 'Trigger',
1717
type: 'string',
1818
hide: true,
19-
width: 90,
19+
width: { min: 90, max: 200 },
2020
array: true,
2121
format: 'enum',
2222
elements: [
@@ -30,7 +30,7 @@ export const columns = writable<Column[]>([
3030
title: 'Method',
3131
type: 'string',
3232
hide: true,
33-
width: 70,
33+
width: { min: 90, max: 200 },
3434
array: true,
3535
format: 'enum',
3636
elements: ['GET', 'POST', 'PUT', 'PATCH', 'DELETE']
@@ -40,7 +40,7 @@ export const columns = writable<Column[]>([
4040
title: 'Status code',
4141
type: 'integer',
4242
hide: true,
43-
width: 100,
43+
width: { min: 100, max: 200 },
4444
format: 'integer',
4545
elements: [
4646
{
@@ -66,7 +66,7 @@ export const columns = writable<Column[]>([
6666
id: 'status',
6767
title: 'Status',
6868
type: 'enum',
69-
width: 130,
69+
width: { min: 130, max: 200 },
7070
array: true,
7171
format: 'enum',
7272
elements: ['completed', 'failed', 'waiting', 'scheduled', 'processing', 'cancelled']
@@ -75,7 +75,8 @@ export const columns = writable<Column[]>([
7575
id: 'duration',
7676
title: 'Duration',
7777
type: 'integer',
78-
width: 80,
78+
width: { min: 80, max: 200 },
79+
7980
format: 'integer',
8081
elements: [
8182
{
@@ -96,7 +97,7 @@ export const columns = writable<Column[]>([
9697
id: '$createdAt',
9798
title: 'Created',
9899
type: 'datetime',
99-
width: 120,
100+
width: { min: 120, max: 200 },
100101
format: 'datetime',
101102
elements: [
102103
{

src/routes/(console)/project-[project]/sites/site-[site]/deploymentsOverview.svelte

+9-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,15 @@
4343
</Button>
4444
</Layout.Stack>
4545
{#if deploymentList?.total}
46-
<Table.Root columns={5} let:root>
46+
<Table.Root
47+
columns={[
48+
{ id: '$id', width: 200 },
49+
{ id: 'status' },
50+
{ id: 'source' },
51+
{ id: 'createdBy' },
52+
{ id: 'actions' }
53+
]}
54+
let:root>
4755
<svelte:fragment slot="header" let:root>
4856
<Table.Header.Cell {root}>Deployment ID</Table.Header.Cell>
4957
<Table.Header.Cell {root}>Status</Table.Header.Cell>

src/routes/(console)/project-[project]/sites/site-[site]/domains/store.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ export const columns = writable<Column[]>([
77
title: 'Domain',
88
type: 'string',
99
format: 'string',
10-
width: { min: 200, max: 700 }
10+
width: { min: 200, max: 550 }
1111
},
1212

1313
{
1414
id: 'redirectUrl',
1515
title: 'Redirect to',
1616
type: 'string',
17-
width: { min: 120, max: 300 }
17+
width: { min: 120, max: 400 }
1818
},
1919
{
2020
id: 'deploymentVcsProviderBranch',
2121
title: 'Production branch',
2222
type: 'string',
23-
width: { min: 90, max: 200 }
23+
width: { min: 90, max: 220 }
2424
}
2525
]);

src/routes/(console)/project-[project]/sites/site-[site]/logs/(components)/LogsRequest.svelte

+11-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,17 @@
8686
{/if}
8787
{:else if requestTab === 'headers'}
8888
{#if selectedLog.requestHeaders?.length}
89-
<Table.Root columns={2} let:root>
89+
<Table.Root
90+
columns={[
91+
{
92+
id: 'key',
93+
width: 200
94+
},
95+
{
96+
id: 'value'
97+
}
98+
]}
99+
let:root>
90100
<svelte:fragment slot="header" let:root>
91101
<Table.Header.Cell {root}>Key</Table.Header.Cell>
92102
<Table.Header.Cell {root}>Value</Table.Header.Cell>

src/routes/(console)/project-[project]/sites/site-[site]/logs/(components)/LogsResponse.svelte

+11-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,17 @@
7373
{/if}
7474
{:else if responseTab === 'headers'}
7575
{#if selectedLog.responseHeaders?.length}
76-
<Table.Root columns={2} let:root>
76+
<Table.Root
77+
columns={[
78+
{
79+
id: 'key',
80+
width: 200
81+
},
82+
{
83+
id: 'value'
84+
}
85+
]}
86+
let:root>
7787
<svelte:fragment slot="header" let:root>
7888
<Table.Header.Cell {root}>Key</Table.Header.Cell>
7989
<Table.Header.Cell {root}>Value</Table.Header.Cell>

src/routes/(console)/project-[project]/sites/site-[site]/settings/+page.svelte

-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@
5252
showConnectRepo.set(true);
5353
}
5454
});
55-
56-
$: console.log(data);
5755
</script>
5856

5957
<Container>

src/routes/(console)/project-[project]/updateVariables.svelte

+5-1
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,11 @@
309309
</Alert.Inline>
310310
{/if}
311311
<Table.Root
312-
columns={[{ id: 'key' }, { id: 'value' }, { id: 'actions', width: 30 }]}
312+
columns={[
313+
{ id: 'key', width: { min: 200, max: 400 } },
314+
{ id: 'value', width: { min: 200, max: 400 } },
315+
{ id: 'actions', width: 50 }
316+
]}
313317
let:root>
314318
<svelte:fragment slot="header" let:root>
315319
<Table.Header.Cell column="key" {root}>Key</Table.Header.Cell>

0 commit comments

Comments
 (0)