refactor(discord-bot): replace static item ID map with Teamcraft tw-items.json lookup

- add `findItemId` method to `teamcraftApp` using cached `_nameToId` map
- update `itemCommand` to use `teamcraftApp.findItemId` instead of static `itemId` map
- update `materiaCommand` to use `teamcraftApp.findItemId` with async `Promise.all` collection
- update `toUniversalisLink` to accept optional `itemId` param; remove `itemId` import
- pass resolved item IDs directly to `toUniversalisLink` at all call sites
- guard `data.listings` with `?? []` since field is now typed as optional

Author: aqzhyi

@apps/discord-bot/src/(features)/commands/itemCommand.ts

@@ -3,7 +3,6 @@ import {
   type ChatInputCommandInteraction,
   SlashCommandBuilder,
 } from 'discord.js'
-import { itemId } from '~/(constants)/itemId'
 import { calcWeightedAvgPrice } from '~/(features)/commands/calcWeightedAvgPrice'
 import { toUniversalisLink } from '~/(features)/markdown/toUniversalisLink'
 import { teamcraftApp } from '~/(services)/teamcraft/teamcraftApp'
@@ -64,13 +63,14 @@ export const itemCommand = {
         .trim()
         .replaceAll('', '')
 
-      const targetItemId = itemId.get(itemName) || null
-
       const result = await interaction.reply(`🔍1️⃣ 搜尋物品與配方...`)
 
       /** 目標物品的生產配方 */
       const targetRecipe = await teamcraftApp.searchRecipes(itemName)
 
+      /** 目標物品的 Universalis item ID（由 Teamcraft tw-items.json 查詢） */
+      const targetItemId = await teamcraftApp.findItemId(itemName)
+
       if (!targetItemId && !targetRecipe) {
         await result.edit(`🔍❌ 找不到相關物品與配方: \`${itemName}\``)
         return
@@ -95,11 +95,11 @@ export const itemCommand = {
           targetItemPricing.nqSaleVelocity = data.nqSaleVelocity
           targetItemPricing.hqSaleVelocity = data.hqSaleVelocity
           targetItemPricing.nqSalePrice = calcWeightedAvgPrice(
-            data.listings,
+            data.listings ?? [],
             false,
           )
           targetItemPricing.hqSalePrice = calcWeightedAvgPrice(
-            data.listings,
+            data.listings ?? [],
             true,
           )
         }
@@ -152,6 +152,7 @@ export const itemCommand = {
 
               const materialLink = toUniversalisLink(
                 materialName ?? '__無資訊__',
+                matId,
               )
 
               if (hqPrice > 0) {
@@ -168,7 +169,7 @@ export const itemCommand = {
 
           await result.edit(
             dedent`
-            ## 📦 **${toUniversalisLink(targetRecipe.resultItemName)}**
+            ## 📦 **${toUniversalisLink(targetRecipe.resultItemName, targetRecipe.resultItemId)}**
             > ${targetRecipe.jobName}配方(\`rlv ${targetRecipe.rlvl}\`)
 
             ### 📊 平均單件售價
@@ -194,7 +195,7 @@ export const itemCommand = {
 
       await result.edit(
         dedent`
-        ## 📦 **${toUniversalisLink(itemName)}**
+        ## 📦 **${toUniversalisLink(itemName, targetItemId)}**
         > 無配方 - ${googleSearchLink}
 
         ### 📊 平均單件售價

@apps/discord-bot/src/(features)/commands/materiaCommand.ts

@@ -5,8 +5,8 @@ import {
 } from 'discord.js'
 import { chunk, keyBy } from 'lodash-es'
 import type { z } from 'zod'
-import { itemId } from '~/(constants)/itemId'
 import { toUniversalisLink } from '~/(features)/markdown/toUniversalisLink'
+import { teamcraftApp } from '~/(services)/teamcraft/teamcraftApp'
 import { universalisApp } from '~/(services)/universalis/universalisApp'
 import { universalisTypes } from '~/(services)/universalis/universalisTypes'
 
@@ -86,19 +86,23 @@ export const materiaCommand = {
     const result = await interaction.reply('🔍 查詢所有魔晶石物價ing...')
 
     // 收集所有魔晶石物品（保持排序）
-    const materiaItems = MATERIA_CONFIG.flatMap((materia) =>
-      TYPE_NAMES.map((typeName, typeIndex) => {
-        const fullName = `${materia.name}${typeName}`
-        const materiaId = itemId.get(fullName)
-        return {
-          ...materia,
-          typeName,
-          typeNumber: typeIndex + 1,
-          fullName,
-          id: materiaId,
-        }
-      }),
-    ).filter((item) => item.id !== undefined)
+    const materiaItemsRaw = MATERIA_CONFIG.flatMap((materia) =>
+      TYPE_NAMES.map((typeName, typeIndex) => ({
+        ...materia,
+        typeName,
+        typeNumber: typeIndex + 1,
+        fullName: `${materia.name}${typeName}`,
+      })),
+    )
+
+    const materiaItems = (
+      await Promise.all(
+        materiaItemsRaw.map(async (item) => ({
+          ...item,
+          id: await teamcraftApp.findItemId(item.fullName),
+        })),
+      )
+    ).filter((item): item is typeof item & { id: number } => item.id !== null)
 
     const allMateriaIds = materiaItems.map((item) => item.id!)
 
@@ -147,7 +151,7 @@ export const materiaCommand = {
         const velocityEmoji = getVelocityEmoji(velocity)
 
         output.push(
-          `${item.emoji} ${toUniversalisLink(item.fullName)} (${item.typeNumber}型${item.attr})` +
+          `${item.emoji} ${toUniversalisLink(item.fullName, item.id)} (${item.typeNumber}型${item.attr})` +
             ` | ` +
             `${velocityEmoji} 銷量市場規模 ${Math.round(velocity).toLocaleString('en-US')}件` +
             ` x ` +

@apps/discord-bot/src/(features)/markdown/toUniversalisLink.ts

@@ -1,9 +1,6 @@
-import { itemId } from '~/(constants)/itemId'
 import { toLink } from '~/(features)/markdown/toLink'
 import { envVar } from '~/envVar'
 
-export function toUniversalisLink(itemName: string) {
-  const _itemId = itemId.get(itemName) || null
-
-  return `${toLink(itemName, `<${envVar.FF14_UNIVERSALIS_SITE_URL}/market/${_itemId}>`)}`
+export function toUniversalisLink(itemName: string, itemId?: number | null) {
+  return `${toLink(itemName, `<${envVar.FF14_UNIVERSALIS_SITE_URL}/market/${itemId ?? null}>`)}`
 }

@apps/discord-bot/src/(services)/teamcraft/teamcraftApp.ts

@@ -84,6 +84,14 @@ export const teamcraftApp = {
     return _idToName!.get(itemId) ?? null
   },
 
+  /**
+   * Returns the FFXIV item ID for a given TW item name, or `null` if not found.
+   */
+  async findItemId(name: string): Promise<number | null> {
+    await loadTwItems()
+    return _nameToId!.get(name) ?? null
+  },
+
   /**
    * Returns the TW job name for a given job ID, or `null` if not found.
    *