Skip to content

Commit 2a1504a

Browse files
authored
Merge pull request #2 from arangodb-helper/3.4-fixes
Fixes found during 3.4 tests
2 parents 00c5164 + a1a676d commit 2a1504a

File tree

6 files changed

+574
-228
lines changed

6 files changed

+574
-228
lines changed

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "arangodb-instance-manager",
3-
"version": "0.1.3",
3+
"version": "1.0.0",
44
"author": "ArangoDB GmbH",
55
"license": "Apache-2.0",
66
"description": "Node server to manage ArangoDB instances",
@@ -15,7 +15,7 @@
1515
"LICENSE"
1616
],
1717
"dependencies": {
18-
"@types/request-promise": "^4.1.41",
18+
"@types/request-promise-native": "^1.0.15",
1919
"arangojs": "^6.2.4",
2020
"dedent": "^0.7.0",
2121
"express": "^4.16.3",
@@ -26,7 +26,7 @@
2626
"path": "^0.12.7",
2727
"portfinder": "^1.0.13",
2828
"request": "^2.85.0",
29-
"request-promise": "^4.2.2",
29+
"request-promise-native": "^1.0.5",
3030
"rmfr": "^2.0.0",
3131
"tmp": "^0.0.33",
3232
"which": "^1.3.0"
@@ -45,4 +45,4 @@
4545
"scripts": {
4646
"compile": "tsc -p . --outDir ./lib/"
4747
}
48-
}
48+
}

src/Instance.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
import { ChildProcess } from "child_process";
2+
import VersionResponse from "./VersionResponse";
3+
4+
export type Role = "agent" | "primary" | "coordinator" | "single";
5+
export type Status = "NEW" | "RUNNING" | "STOPPED" | "EXITED" | "KILLED";
26

37
export default interface Instance {
48
name: string;
@@ -7,9 +11,11 @@ export default interface Instance {
711
binary?: string;
812
args: string[];
913
port?: string;
10-
status: string;
14+
status: Status;
1115
exitcode: number | null;
1216
process: ChildProcess | null;
1317
logFn: (line: string) => void;
14-
role: string;
18+
role: Role;
19+
id?: string;
20+
version?: VersionResponse;
1521
}

0 commit comments

Comments
 (0)