finalize

Author: ardabeyazoglu

README.md

@@ -1,10 +1,31 @@
 # php-ds-array-benchmark
 
-A synthetic benchmark comparison between native Array, SplFixedArray and Deque/Vector from php-ds.
+A php8.2 benchmark comparison between native **Array**, **SplFixedArray** and **Vector** from php-ds (data-structures extensions).
 
 # Usage
 
-	./vendor/bin/phpbench run tests/Benchmark --report=default
-	./vendor/bin/phpbench run tests/Benchmark --report=aggregate
+	./vendor/bin/phpbench run tests/Benchmark --report=aggregate --retry-threshold=5
 
+# Result
 
+### Without json_encode
+
+| benchmark  | subject            | set | revs | its | mem_peak | mode        | rstdev |
+|------------|--------------------|-----|------|-----|----------|-------------|--------|
+| ArrayBench | benchArray         |     | 10   | 3   | 1.126gb  | 492.811ms   | ±1.31% |
+| ArrayBench | benchSplFixedArray |     | 10   | 3   | 1.087gb  | 537.613ms   | ±2.15% |
+| ArrayBench | benchDsVector      |     | 10   | 3   | 1.084gb  | 1,021.727ms | ±0.19% |
+
+### With json_encode
+
+| benchmark  | subject            | set | revs | its | mem_peak | mode        | rstdev |
+|------------|--------------------|-----|------|-----|----------|-------------|--------|
+| ArrayBench | benchArray         |     | 10   | 3   | 1.405gb  | 1,565.699ms | ±1.01% |
+| ArrayBench | benchSplFixedArray |     | 10   | 3   | 1.600gb  | 2,087.920ms | ±0.71% |
+| ArrayBench | benchDsVector      |     | 10   | 3   | 1.388gb  | 2,137.282ms | ±0.61% |
+
+# Conclusion
+
+- **Native array is the best data structure for lists, and outperforms the other methods in both time complexity and overall resource usage.**
+- SplFixedArray is simply garbage for php8. It has no value over array in any way.
+- DataStructures extension was once a great improvement for php7, but so much anymore, at least for simple lists. Certain things can be still much more efficient with [php-ds](https://medium.com/@rtheunissen/efficient-data-structures-for-php-7-9dda7af674cd).

tests/Benchmark/ArrayBench.php

@@ -8,13 +8,13 @@
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\OutputTimeUnit;
 use SplFixedArray;
-use Ds\Deque;
+use Ds\Vector;
 
 /**
  * @BeforeMethods({"init"})
  * @AfterMethods({"tearDown"})
- * @Iterations(5)
- * @Revs(50)
+ * @Iterations(3)
+ * @Revs(10)
  * @OutputTimeUnit("milliseconds", precision=3)
  */
 class ArrayBench
@@ -25,7 +25,8 @@ class ArrayBench
 
     public function init()
     {
-        $this->data = require_once("data/sample_data.php");
+        $data = require("data/sample_data.php");
+        $this->data = array_merge($data, $data, $data, $data, $data, $data, $data, $data);
         $this->colCount = count($this->data[0]);
         $this->count = count($this->data);
     }
@@ -39,11 +40,9 @@ public function benchArray()
     {
         $data = [];
         foreach ($this->data as $values) {
-            $row = [
-                "cells" => []
-            ];
+            $cells = [];
             foreach ($values as $col => $value) {
-                $row["cells"][] = [
+                $cells[] = [
                     "colspan" => 2,
                     "rowspan" => 4,
                     "column" => $col,
@@ -54,22 +53,21 @@ public function benchArray()
                     ],
                 ];
             }
-            $data[] = $row;
+            $data[] = $cells;
         }
 
+        //return $data;
         return json_encode($data);
     }
 
     public function benchSplFixedArray()
     {
         $data = new SplFixedArray($this->count);
         foreach ($this->data as $key => $values) {
-            $row = [
-                "cells" => new SplFixedArray($this->colCount)
-            ];
+            $cells = new SplFixedArray($this->colCount);
             $i = 0;
             foreach ($values as $col => $value) {
-                $row["cells"][$i++] = [
+                $cells[$i++] = [
                     "colspan" => 2,
                     "rowspan" => 4,
                     "column" => $col,
@@ -80,23 +78,23 @@ public function benchSplFixedArray()
                     ],
                 ];
             }
-            $data[$key] = $row;
+            $data[$key] = $cells;
         }
 
+        //return $data;
         return json_encode($data);
     }
 
     public function benchDsVector()
     {
-        $data = new Deque();
+        $data = new Vector();
         $data->allocate($this->count);
         foreach ($this->data as $values) {
-            $row = [
-                "cells" => new Deque()
-            ];
-            $row["cells"]->allocate($this->colCount);
+            $cells = new Vector();
+            $cells->allocate($this->colCount);
+
             foreach ($values as $col => $value) {
-                $row["cells"]->push([
+                $cells->push([
                     "colspan" => 2,
                     "rowspan" => 4,
                     "column" => $col,
@@ -107,9 +105,10 @@ public function benchDsVector()
                     ],
                 ]);
             }
-            $data->push($row);
+            $data->push($cells);
         }
 
+        //return $data;
         return json_encode($data);
     }