Skip to content

Commit 0993fb7

Browse files
committed
rename handleResult to resolveExternalValue
1 parent fb98d35 commit 0993fb7

10 files changed

+9
-9
lines changed

packages/delegate/src/defaultMergedResolver.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { defaultFieldResolver, GraphQLResolveInfo } from 'graphql';
22

33
import { getResponseKeyFromInfo } from '@graphql-tools/utils';
44

5-
import { handleResult } from './results/handleResult';
5+
import { resolveExternalValue } from './resolveExternalValue';
66
import { getSubschema } from './Subschema';
77
import { getErrors, isExternalData } from './externalData';
88
import { ExternalData } from './types';
@@ -31,9 +31,9 @@ export function defaultMergedResolver(
3131
return defaultFieldResolver(parent, args, context, info);
3232
}
3333

34-
const result = parent[responseKey];
34+
const data = parent[responseKey];
3535
const subschema = getSubschema(parent, responseKey);
3636
const errors = getErrors(parent, responseKey);
3737

38-
return handleResult(result, errors, subschema, context, info);
38+
return resolveExternalValue(data, errors, subschema, context, info);
3939
}

packages/delegate/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export { delegateToSchema, delegateRequest } from './delegateToSchema';
22
export { createRequestFromInfo, createRequest } from './createRequest';
33
export { defaultMergedResolver } from './defaultMergedResolver';
4-
export { handleResult } from './results/handleResult';
4+
export { resolveExternalValue } from './resolveExternalValue';
55
export { Subschema, isSubschema, isSubschemaConfig, cloneSubschemaConfig, getSubschema } from './Subschema';
66

77
export * from './applySchemaTransforms';

packages/delegate/src/results/handleResult.ts renamed to packages/delegate/src/resolveExternalValue/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { handleObject } from './handleObject';
1616
import { handleList } from './handleList';
1717
import { extendedError } from '@graphql-tools/utils';
1818

19-
export function handleResult(
19+
export function resolveExternalValue(
2020
result: any,
2121
errors: ReadonlyArray<GraphQLError>,
2222
subschema: GraphQLSchema | SubschemaConfig,

packages/delegate/src/transforms/CheckResultAndHandleErrors.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { GraphQLResolveInfo, GraphQLOutputType, GraphQLSchema } from 'graphql';
22

33
import { getResponseKeyFromInfo, ExecutionResult } from '@graphql-tools/utils';
4-
import { handleResult } from '../results/handleResult';
4+
import { resolveExternalValue } from '../resolveExternalValue';
55
import { SubschemaConfig, Transform, DelegationContext } from '../types';
66

77
export default class CheckResultAndHandleErrors implements Transform {
@@ -57,5 +57,5 @@ export function checkResultAndHandleErrors(
5757
const errors = result.errors != null ? result.errors : [];
5858
const data = result.data != null ? result.data[responseKey] : undefined;
5959

60-
return handleResult(data, errors, subschema, context, info, returnType, skipTypeMerging);
60+
return resolveExternalValue(data, errors, subschema, context, info, returnType, skipTypeMerging);
6161
}

packages/wrap/src/generateProxyingResolvers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Operation, getResponseKeyFromInfo } from '@graphql-tools/utils';
44
import {
55
delegateToSchema,
66
getSubschema,
7-
handleResult,
7+
resolveExternalValue,
88
SubschemaConfig,
99
isSubschemaConfig,
1010
CreateProxyingResolverFn,
@@ -100,7 +100,7 @@ function createPossiblyNestedProxyingResolver(
100100
// This can happen even for a root field when the root type ia
101101
// also nested as a field within a different type.
102102
if (subschemaOrSubschemaConfig === subschema && parent[responseKey] !== undefined) {
103-
return handleResult(parent[responseKey], errors, subschema, context, info);
103+
return resolveExternalValue(parent[responseKey], errors, subschema, context, info);
104104
}
105105
}
106106
}

0 commit comments

Comments
 (0)