fix(mergeSchemas): handle entire SDL surface

mergeSchemas dummy types should handle entire SDL surface prior to better prepare for rewiring with actual types

closes #1399

Author: yaacovCR

src/stitch/typeFromAST.ts

@@ -26,6 +26,7 @@ import {
   TokenKind,
   GraphQLEnumValueConfigMap,
   GraphQLFieldConfigArgumentMap,
+  valueFromASTUntyped,
 } from 'graphql';
 
 import { graphqlVersion } from '../utils/index';
@@ -67,12 +68,13 @@ export default function typeFromAST(
 function makeObjectType(node: ObjectTypeDefinitionNode): GraphQLObjectType {
   const config = {
     name: node.name.value,
-    fields: () => makeFields(node.fields),
+    description: getDescription(node, backcompatOptions),
     interfaces: () =>
       node.interfaces.map((iface) =>
         createNamedStub(iface.name.value, 'interface'),
       ),
-    description: getDescription(node, backcompatOptions),
+    fields: () => makeFields(node.fields),
+    astNode: node,
   };
   return new GraphQLObjectType(config);
 }
@@ -82,16 +84,17 @@ function makeInterfaceType(
 ): GraphQLInterfaceType {
   const config = {
     name: node.name.value,
-    fields: () => makeFields(node.fields),
+    description: getDescription(node, backcompatOptions),
     interfaces:
       graphqlVersion() >= 15
         ? () =>
             ((node as unknown) as ObjectTypeDefinitionNode).interfaces.map(
               (iface) => createNamedStub(iface.name.value, 'interface'),
             )
         : undefined,
-    description: getDescription(node, backcompatOptions),
+    fields: () => makeFields(node.fields),
     resolveType: (parent: any) => resolveFromParentTypename(parent),
+    astNode: node,
   };
   return new GraphQLInterfaceType(config);
 }
@@ -109,18 +112,20 @@ function makeEnumType(node: EnumTypeDefinitionNode): GraphQLEnumType {
 
   return new GraphQLEnumType({
     name: node.name.value,
-    values,
     description: getDescription(node, backcompatOptions),
+    values,
+    astNode: node,
   });
 }
 
 function makeUnionType(node: UnionTypeDefinitionNode): GraphQLUnionType {
   return new GraphQLUnionType({
     name: node.name.value,
+    description: getDescription(node, backcompatOptions),
     types: () =>
       node.types.map((type) => createNamedStub(type.name.value, 'object')),
-    description: getDescription(node, backcompatOptions),
     resolveType: (parent) => resolveFromParentTypename(parent),
+    astNode: node,
   });
 }
 
@@ -135,6 +140,7 @@ function makeScalarType(node: ScalarTypeDefinitionNode): GraphQLScalarType {
     // always pass validation.
     parseValue: () => false,
     parseLiteral: () => false,
+    astNode: node,
   });
 }
 
@@ -143,8 +149,9 @@ function makeInputObjectType(
 ): GraphQLInputObjectType {
   return new GraphQLInputObjectType({
     name: node.name.value,
-    fields: () => makeValues(node.fields),
     description: getDescription(node, backcompatOptions),
+    fields: () => makeValues(node.fields),
+    astNode: node,
   });
 }
 
@@ -169,9 +176,10 @@ function makeFields(
       ...prev,
       [node.name.value]: {
         type: createStub(node.type, 'output'),
-        args: makeValues(node.arguments),
         description: getDescription(node, backcompatOptions),
+        args: makeValues(node.arguments),
         deprecationReason,
+        astNode: node,
       },
     };
   }, {});
@@ -185,8 +193,9 @@ function makeValues(
       ...prev,
       [node.name.value]: {
         type: createStub(node.type, 'input'),
-        defaultValue: node.defaultValue,
+        defaultValue: valueFromASTUntyped(node.defaultValue),
         description: getDescription(node, backcompatOptions),
+        astNode: node,
       },
     }),
     {},
@@ -203,8 +212,10 @@ function makeDirective(node: DirectiveDefinitionNode): GraphQLDirective {
   return new GraphQLDirective({
     name: node.name.value,
     description: node.description != null ? node.description.value : null,
-    args: makeValues(node.arguments),
     locations,
+    isRepeatable: node.repeatable,
+    args: makeValues(node.arguments),
+    astNode: node,
   });
 }
 

src/test/alternateMergeSchemas.test.ts

@@ -9,6 +9,7 @@ import {
   printSchema,
   graphqlSync,
   GraphQLField,
+  assertValidSchema,
 } from 'graphql';
 
 import {
@@ -1918,3 +1919,19 @@ describe('mergeTypes', () => {
     });
   });
 });
+
+describe('mergeSchemas handles typeDefs with default values', () => {
+  test('it works', () => {
+    const typeDefs = `
+      type Query {
+        foo(arg: String = "1"): String
+      }
+    `;
+
+    const schema = makeExecutableSchema({ typeDefs });
+    assertValidSchema(schema);
+
+    const mergedSchema = mergeSchemas({ typeDefs });
+    assertValidSchema(mergedSchema);
+  });
+});