Run tests with all Node frameworks, fix ReadableStream.cancel & remove URL ponyfill (#1929)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: ardatan

.changeset/@whatwg-node_fetch-1929-dependencies.md

@@ -0,0 +1,5 @@
+---
+"@whatwg-node/fetch": patch
+---
+dependencies updates:
+  - Updated dependency [`@whatwg-node/node-fetch@^0.7.5` ↗︎](https://www.npmjs.com/package/@whatwg-node/node-fetch/v/0.7.5) (from `^0.7.1`, in `dependencies`)

.changeset/@whatwg-node_node-fetch-1929-dependencies.md

@@ -0,0 +1,6 @@
+---
+"@whatwg-node/node-fetch": patch
+---
+dependencies updates:
+  - Removed dependency [`@kamilkisiela/fast-url-parser@^1.1.4` ↗︎](https://www.npmjs.com/package/@kamilkisiela/fast-url-parser/v/1.1.4) (from `dependencies`)
+  - Removed dependency [`fast-querystring@^1.1.1` ↗︎](https://www.npmjs.com/package/fast-querystring/v/1.1.1) (from `dependencies`)

.changeset/warm-plums-grin.md

@@ -0,0 +1,31 @@
+---
+'@whatwg-node/node-fetch': patch
+---
+
+- Remove URL ponyfill implementation based on `fast-url-parser` and `fast-querystring`, because Node now uses Ada URL parser which is fast enough.
+
+- Fix `ReadableStream[Symbol.asyncIterator]`
+
+`ReadableStream` uses `Readable` so it uses `Symbol.asyncIterator` method of `Readable` but the returned iterator's `.return` method doesn't handle cancellation correctly. So we need to call `readable.destroy(optionalError)` manually to cancel the stream.
+
+This allows `ReadableStream` to use implementations relying on `AsyncIterable.cancel` to handle cancellation like `Readable.from`
+
+Previously the following was not handling cancellation;
+
+```ts
+const res = new ReadableStream({
+  start(controller) {
+    controller.enqueue('Hello');
+    controller.enqueue('World');
+  },
+  cancel(reason) {
+    console.log('cancelled', reason);
+  }
+});
+
+const readable = Readable.from(res);
+
+readable.destroy(new Error('MY REASON'));
+
+// Should log 'cancelled MY REASON'
+```

.eslintrc.json

@@ -65,7 +65,8 @@
     "website",
     "scripts",
     "e2e",
-    "benchmarks"
+    "benchmarks",
+    "deno-jest.ts"
   ],
   "globals": {
     "BigInt": true

.github/workflows/deployment-e2e.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        plan: ['aws-lambda', 'azure-function', 'cloudflare-workers', 'cloudflare-modules', 'deno']
+        plan: ['aws-lambda', 'azure-function', 'cloudflare-workers', 'cloudflare-modules']
         # TODO: Add vercel
     name: e2e / ${{ matrix.plan }}
 
@@ -27,12 +27,6 @@ jobs:
       - name: Install Required Libraries
         run: sudo apt update && sudo apt install -y libcurl4-openssl-dev libssl-dev
 
-      - name: Use Deno
-        if: matrix.plan == 'deno'
-        uses: denoland/setup-deno@v2
-        with:
-          deno-version: vx.x.x
-
       - name: Cache Node Modules
         uses: actions/cache@v4
         id: node-modules-cache-deployment-e2e

.github/workflows/tests.yml

@@ -8,6 +8,7 @@ on:
 
 env:
   NODE_OPTIONS: --max-old-space-size=4096
+  NODE_NO_WARNINGS: 1
   CI: true
 
 jobs:
@@ -97,15 +98,13 @@ jobs:
           command: yarn test:leaks --ci
 
   unit-bun:
-    name: unit / bun ${{matrix.node-version}}
+    name: unit / bun
     runs-on: ubuntu-latest
     services:
       httpbin:
         image: kennethreitz/httpbin
         ports:
           - 8888:80
-    strategy:
-      fail-fast: false
     steps:
       - name: Checkout Master
         uses: actions/checkout@v4
@@ -115,16 +114,33 @@ jobs:
         uses: the-guild-org/shared-config/setup@main
         with:
           nodeVersion: 22
-      - name: Cache Jest
-        uses: actions/cache@v4
-        with:
-          path: .cache/jest
-          key: ${{ runner.os }}-${{matrix.node-version}}-jest-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-${{matrix.node-version}}-jest-
       - name: Test
         run: yarn test:bun --ci
 
+  unit-deno:
+    name: unit / deno
+    runs-on: ubuntu-latest
+    services:
+      httpbin:
+        image: kennethreitz/httpbin
+        ports:
+          - 8888:80
+    steps:
+      - name: Checkout Master
+        uses: actions/checkout@v4
+      - name: Install Required Libraries
+        run: sudo apt update && sudo apt install -y libcurl4-openssl-dev libssl-dev
+      - name: Setup env
+        uses: the-guild-org/shared-config/setup@main
+        with:
+          nodeVersion: 22
+      - name: Test
+        uses: nick-fields/retry@v3
+        with:
+          timeout_minutes: 10
+          max_attempts: 5
+          command: yarn test:deno
+
   esm:
     name: esm
     runs-on: ubuntu-latest

.gitignore

@@ -76,3 +76,5 @@ junit.xml
 package-lock.json
 
 eslint_report.json
+
+deno.lock

.yarnrc

@@ -0,0 +1 @@
+ignore-engines true

benchmarks/node-fetch/server.ts

@@ -1,4 +1,4 @@
-import { createServer } from 'http';
+import { createServer } from 'node:http';
 import { isScenario, scenarios } from './scenarios';
 
 const port = 50001;

benchmarks/server/server.ts

@@ -1,5 +1,5 @@
-import { Blob as BufferBlob } from 'buffer';
-import { createServer, type RequestListener } from 'http';
+import { Blob as BufferBlob } from 'node:buffer';
+import { createServer, type RequestListener } from 'node:http';
 import * as undici from 'undici';
 import { createServerAdapter, Response } from '@whatwg-node/server';
 

deno-jest.ts

@@ -0,0 +1,22 @@
+import { fn } from 'jsr:@std/expect';
+
+export {
+  describe,
+  it,
+  test,
+  beforeEach,
+  afterEach,
+  beforeAll,
+  afterAll,
+} from 'jsr:@std/testing/bdd';
+export { expect } from 'jsr:@std/expect';
+
+export const jest = {
+  fn,
+  spyOn(target: any, method: string) {
+    Object.defineProperty(target, method, {
+      value: fn(target[method]),
+      writable: true,
+    });
+  },
+};

deno.json

@@ -0,0 +1,13 @@
+{
+  "imports": {
+    "@jest/globals": "./deno-jest.ts",
+    "@whatwg-node/cookie-store": "./packages/cookie-store/src/index.ts",
+    "@whatwg-node/disposablestack": "./packages/disposablestack/src/index.ts",
+    "@whatwg-node/fetch": "./packages/fetch/dist/esm-ponyfill.js",
+    "@whatwg-node/events": "./packages/events/src/index.ts",
+    "fetchache": "./packages/fetchache/src/index.ts",
+    "@whatwg-node/node-fetch": "./packages/node-fetch/src/index.ts",
+    "@whatwg-node/server": "./packages/server/src/index.ts",
+    "@whatwg-node/server-plugin-cookies": "./packages/server-plugin-cookies/src/index.ts"
+  }
+}

e2e/aws-lambda/scripts/createAwsLambdaDeployment.ts

@@ -1,4 +1,4 @@
-import { join } from 'path';
+import { join } from 'node:path';
 import {
   assertDeployedEndpoint,
   DeploymentConfiguration,

e2e/aws-lambda/src/index.ts

@@ -1,3 +1,4 @@
+import { Buffer } from 'node:buffer';
 import { APIGatewayEvent, APIGatewayProxyResult, Context } from 'aws-lambda';
 import { createTestServerAdapter } from '@e2e/shared-server';
 import { URL } from '@whatwg-node/fetch';

e2e/azure-function/scripts/createAzureFunctionDeployment.ts

@@ -1,4 +1,4 @@
-import { join } from 'path';
+import { join } from 'node:path';
 import {
   assertDeployedEndpoint,
   DeploymentConfiguration,

e2e/cloudflare-workers/scripts/createCfDeployment.ts

@@ -1,4 +1,4 @@
-import { join } from 'path';
+import { join } from 'node:path';
 import {
   assertDeployedEndpoint,
   DeploymentConfiguration,