Skip to content

Expose libmodbus's flush command #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose libmodbus's flush command #133

wants to merge 1 commit into from

Conversation

pomplesiegel
Copy link

  • Expose libmodbus's flush command to ModbusRTUServer API
  • This command proved to be necessary for stable operation for large reads at low baud rates on the RP2040. May be important for cross-platform compatibility

@pomplesiegel
Expose libmodbus's flush command
5c93b08 
* Expose libmodbus's flush command to ModbusRTUServer API
@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pomplesiegel pomplesiegel mentioned this pull request Dec 19, 2023
Open
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 20, 2023
@github-actions GitHub Actions
Copy link

Memory usage change @ 5c93b08

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +72 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:megaavr:uno2018:mode=off 🔺 +12 - +12 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +8 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientParameters
flash		 % examples/RTU/ModbusRTUClientParameters
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 72 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:megaavr:uno2018:mode=off 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0 12 0.02 0 0.0
arduino:samd:mkrwifi1010 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientParameters<br>flash,%,examples/RTU/ModbusRTUClientParameters<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,72,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,,,,,
arduino:megaavr:uno2018:mode=off,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0
arduino:samd:mkrwifi1010,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pomplesiegel @CLAassistant @per1234