Skip to content

Update repositories.txt #6241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Update repositories.txt #6241

merged 1 commit into from
Apr 26, 2025

Conversation

eyr1n
Copy link
Contributor

@eyr1n eyr1n commented Apr 26, 2025

Added https://github.com/eyr1n/esp32-ps3

The original repository (https://github.com/jvpernis/esp32-ps3) may no longer be maintained, so I created a forked library.
The fork fixed a problem with building with the latest ESP32 board library (v3.2.0).

Copy link
Contributor

A problem was found with your submission https://github.com/eyr1n/esp32-ps3

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Apr 26, 2025
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @eyr1n
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@eyr1n
Copy link
Contributor Author

eyr1n commented Apr 26, 2025

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/eyr1n/esp32-ps3:

Linting library in esp32-ps3
INFO: No header file found matching library name (Fork_of_PS3_Controller_Host.h). Best practices are for primary header 
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Fork of PS3 Controller Host contains spaces. Although supported, best practices is to  
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in esp32-ps3/examples/Ps3Accelerometer

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3Address

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3Connect

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3Data

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3DataNotify

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3Demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in esp32-ps3/examples/Ps3Rumble

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit fed98b4 into arduino:main Apr 26, 2025
14 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/eyr1n/esp32-ps3/

github-actions bot pushed a commit that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant