-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(repo-server): Declare custom trust certs for repo-server and plugins #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olivergondza
wants to merge
15
commits into
argoproj-labs:master
Choose a base branch
from
olivergondza:ClusterTrustBundle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5da4d1f
feat(repo-server): Declare custom trust anchors to use by repo-server…
olivergondza 0c6e8c1
feat(repo-server): Use custom trust anchors to use by repo-server or …
olivergondza f291a2c
feat(repo-server): Refactor trust cert injection
olivergondza d2507d0
feat(repo-server): Update generated code
olivergondza 9bfd0be
feat(repo-server): Address linting errors
olivergondza 2c4420e
feat(repo-server): Please gosec
olivergondza f9e6bad
feat(repo-server): Use more generic test name
olivergondza 7e6055e
feat(repo-server): Reflect master changes
olivergondza 1165074
fix: Fix tests, the cluster-wide resource likely do not exist
olivergondza 7be1d86
docs: Document spec.repo.systemCATrust
olivergondza ddb777d
feat(ci-build): Run tests with the feature flags on
olivergondza 10ac40b
feat(repo-server): Update tests to verify on clusters with or without…
olivergondza 12c425e
feat(repo-server): Use reconciler hooks
olivergondza 438c732
Unify tests with downstream
olivergondza 9c3639c
feat(repo-server): Propagate changes from Secrets/ConfigMaps/ClusterT…
olivergondza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be
SecretRefsinstead ofSecretProjection? What is the advantage we get by usingSecretProjectioninstead of referring aSecretdirectly which can be read directly by the operator code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, projections are the only way (I know off), to create a single volume from multiple sources. So this can combine all three kinds of sources in any quantity, and the entries will be merged in a single directory making the init container completely agnostic of files' origin.
If customers are to create the Secret or CM manually, using only one resource might not be that much to ask. But ability to merge them permits seemless integration with signed
ClusterTrustBundlesthat are likely to have more than one resource.