You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upon running make codegen local, I receive: Could not make proto path relative: 025/01/13 11:40:17 protoc -I . -I /Users/codefresh/go/src/ -I /Users/codefresh/GolandProjects/argo-cd/vendor -I /Users/codefresh/GolandProjects/argo-cd/dist/protoc-include --gogo_out=/Users/codefresh/go/src/ /Users/codefresh/go/src/github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1/generated.proto
2025/01/13 11:40:17 Could not make proto path relative: /Users/codefresh/go/src/github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1/generated.proto: No such file or directory
The reason is that codegen-local is using ~/go/src/ ($GOPATH) during run, and in my case, while the Argo CD repo was cloned under ~/GolandProjects/argo-cd, there also existed an older clone inder $GOPATH, so the old files in $GOPATH were used.
While investigating this, it became clear that we don't require the repo to be cloned under $GOPATH anymore, it can be cloned anywhere, and that GOPATH should not be used unless the active repo WAS cloned there initially.
So the docs should be updated with removing the requirement for $GOPATH and the above clarification. To Reproduce
Clone the Argo CD repo to any path NOT under ~/go/src/ .
Then clone the Argo CD repo to ~/go/src, and checkout some really old release branch.
run make codegen-local on the FIRST repo and observe it fails.
Additionally, the docs for contributors about the available make targets are not up to date, so it is beneficial to update those.
Expected behavior
make codegen-local finishes successfully
Screenshots
Version
Latest commit on master branch
v2.14.0+4d98359
Logs
Paste any relevant application logs here.
The text was updated successfully, but these errors were encountered:
Checklist:
argocd version
.Describe the bug
Upon running
make codegen local
, I receive: Could not make proto path relative: 025/01/13 11:40:17 protoc -I . -I /Users/codefresh/go/src/ -I /Users/codefresh/GolandProjects/argo-cd/vendor -I /Users/codefresh/GolandProjects/argo-cd/dist/protoc-include --gogo_out=/Users/codefresh/go/src/ /Users/codefresh/go/src/github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1/generated.proto2025/01/13 11:40:17 Could not make proto path relative: /Users/codefresh/go/src/github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1/generated.proto: No such file or directory
The reason is that
codegen-local
is using~/go/src/
($GOPATH
) during run, and in my case, while the Argo CD repo was cloned under~/GolandProjects/argo-cd
, there also existed an older clone inder$GOPATH
, so the old files in$GOPATH
were used.While investigating this, it became clear that we don't require the repo to be cloned under
$GOPATH
anymore, it can be cloned anywhere, and thatGOPATH
should not be used unless the active repo WAS cloned there initially.So the docs should be updated with removing the requirement for $GOPATH and the above clarification.
To Reproduce
Clone the Argo CD repo to any path NOT under ~/go/src/ .
Then clone the Argo CD repo to ~/go/src, and checkout some really old release branch.
run make codegen-local on the FIRST repo and observe it fails.
Additionally, the docs for contributors about the available
make
targets are not up to date, so it is beneficial to update those.Expected behavior
make codegen-local finishes successfully
Screenshots
Version
Latest commit on master branch
Logs
The text was updated successfully, but these errors were encountered: