Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Code Block (For Reference) to Sync Wave Documentation Page #21490

Open
josephaw1022 opened this issue Jan 14, 2025 · 0 comments
Open
Labels
component:docs enhancement New feature or request

Comments

@josephaw1022
Copy link

josephaw1022 commented Jan 14, 2025

Summary

⚠️ Small Docs Update

In the sync waves page https://argo-cd.readthedocs.io/en/stable/user-guide/sync-waves/

I think a short code block that shows how the ARGOCD_SYNC_WAVE_DELAY in the helm chart can be configured

like this

controller:
  env:
    - name: ARGOCD_SYNC_WAVE_DELAY
      value: "30"

Motivation

  • my first question was is the default value 2 or 2s

    • was able to figure it out by looking at the code, here but I think just having it in the page would make it easier
  • wasn't sure how to configure this in the helm chart initially

Proposal

add a code block below the following note in the docs

Note: there is a delay between each sync wave to give other controllers a chance to react to the applied spec change. This prevents Argo CD from assessing resource health too quickly (against a stale object), and firing hooks prematurely. The default delay between each sync wave is 2 seconds. This can be adjusted by setting the ARGOCD_SYNC_WAVE_DELAY environment variable in the argocd-application-controller deployment.


@josephaw1022 josephaw1022 added the enhancement New feature or request label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants