refactor: clean up clippy setup

Author: huitseeker

.cargo/config

@@ -18,6 +18,7 @@ xclippy = [
     "-Wclippy::from_iter_instead_of_collect",
     "-Wclippy::implicit_clone",
     "-Wclippy::inefficient_to_string",
+    "-Wclippy::invalid_upcast_comparisons",
     "-Wclippy::large_stack_arrays",
     "-Wclippy::large_types_passed_by_value",
     "-Wclippy::macro_use_imports",

.clippy.toml

@@ -0,0 +1,2 @@
+type-complexity-threshold = 1200
+too-many-arguments-threshold = 20

core/src/alu/add_sub/mod.rs

@@ -170,6 +170,7 @@ where
         );
 
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.operand_1[0] * local.operand_1[0] * local.operand_1[0]
                 - local.operand_1[0] * local.operand_1[0] * local.operand_1[0],

core/src/alu/bitwise/mod.rs

@@ -143,6 +143,7 @@ where
         );
 
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         );

core/src/alu/divrem/mod.rs

@@ -743,6 +743,7 @@ where
         }
 
         // A dummy constraint to keep the degree 3.
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         )

core/src/alu/lt/mod.rs

@@ -195,6 +195,7 @@ where
         let one = AB::Expr::one();
 
         // Dummy degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         );

core/src/alu/mul/mod.rs

@@ -427,6 +427,7 @@ where
         builder.receive_alu(opcode, local.a, local.b, local.c, local.is_real);
 
         // A dummy constraint to keep the degree at least 3.
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         );

core/src/alu/sll/mod.rs

@@ -334,6 +334,7 @@ where
         );
 
         // A dummy constraint to keep the degree at least 3.
+        #[allow(clippy::eq_op)]
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         );

core/src/alu/sr/mod.rs

@@ -448,6 +448,8 @@ where
             }
         }
 
+        #[allow(clippy::eq_op)]
+        // A dummy constraint to keep the degree at least 3.
         builder.assert_zero(
             local.a[0] * local.b[0] * local.c[0] - local.a[0] * local.b[0] * local.c[0],
         );

core/src/bytes/air.rs

@@ -78,6 +78,7 @@ impl<AB: SP1AirBuilder> Air<AB> for ByteChip<AB::F> {
         }
 
         // Dummy constraint for normalizing to degree 3.
+        #[allow(clippy::eq_op)]
         builder.assert_zero(local.b * local.b * local.b - local.b * local.b * local.b);
     }
 }

core/src/lib.rs

@@ -1,14 +1,9 @@
 #![allow(
-    clippy::eq_op,
     clippy::new_without_default,
     clippy::field_reassign_with_default,
-    clippy::unnecessary_cast,
     clippy::cast_abs_to_unsigned,
     clippy::needless_range_loop,
-    clippy::type_complexity,
-    clippy::unnecessary_unwrap,
     clippy::default_constructed_unit_structs,
-    clippy::box_default,
     deprecated
 )]
 

core/src/operations/add.rs

@@ -103,6 +103,7 @@ impl<F: Field> AddOperation<F> {
         }
 
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(a[0] * b[0] * cols.value[0] - a[0] * b[0] * cols.value[0]);
     }
 }

core/src/operations/add4.rs

@@ -147,6 +147,7 @@ impl<F: Field> Add4Operation<F> {
         }
 
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(a[0] * b[0] * cols.value[0] - a[0] * b[0] * cols.value[0]);
     }
 }

core/src/operations/add5.rs

@@ -167,6 +167,7 @@ impl<F: Field> Add5Operation<F> {
         }
 
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(is_real * is_real * is_real - is_real * is_real * is_real);
     }
 }

core/src/operations/field/extensions/quadratic.rs

@@ -459,6 +459,7 @@ mod tests {
                 .eval::<AB, P, _, _>(builder, &local.a, &local.b, self.operation);
 
             // A dummy constraint to keep the degree 3.
+            #[allow(clippy::eq_op)]
             builder.assert_zero(
                 local.a[0][0] * local.b[0][0] * local.a[0][0]
                     - local.a[0][0] * local.b[0][0] * local.a[0][0],

core/src/operations/field/field_den.rs

@@ -250,6 +250,7 @@ mod tests {
                 .eval::<AB, P>(builder, &local.a, &local.b, self.sign);
 
             // A dummy constraint to keep the degree 3.
+            #[allow(clippy::eq_op)]
             builder.assert_zero(
                 local.a[0] * local.b[0] * local.a[0] - local.a[0] * local.b[0] * local.a[0],
             )

core/src/operations/field/field_inner_product.rs

@@ -241,6 +241,7 @@ mod tests {
                 .eval::<AB, P, _>(builder, local.a.clone(), local.b.clone());
 
             // A dummy constraint to keep the degree 3.
+            #[allow(clippy::eq_op)]
             builder.assert_zero(
                 local.a[0][0] * local.b[0][0] * local.a[0][0]
                     - local.a[0][0] * local.b[0][0] * local.a[0][0],

core/src/operations/field/field_op.rs

@@ -301,6 +301,7 @@ mod tests {
                 .eval::<AB, P, _, _>(builder, &local.a, &local.b, self.operation);
 
             // A dummy constraint to keep the degree 3.
+            #[allow(clippy::eq_op)]
             builder.assert_zero(
                 local.a[0] * local.b[0] * local.a[0] - local.a[0] * local.b[0] * local.a[0],
             )

core/src/operations/field/field_sqrt.rs

@@ -192,6 +192,7 @@ mod tests {
             local.sqrt.eval::<AB, P>(builder, &local.a);
 
             // A dummy constraint to keep the degree 3.
+            #[allow(clippy::eq_op)]
             builder.assert_zero(
                 local.a[0] * local.a[0] * local.a[0] - local.a[0] * local.a[0] * local.a[0],
             )

core/src/operations/not.rs

@@ -53,6 +53,7 @@ impl<F: Field> NotOperation<F> {
         }
 
         // A dummy constraint to keep the degree 3.
+        #[allow(clippy::eq_op)]
         builder.assert_zero(a[0] * a[0] * a[0] - a[0] * a[0] * a[0]);
     }
 }

core/src/runtime/mod.rs

@@ -343,7 +343,6 @@ impl Runtime {
     }
 
     /// Emit a CPU event.
-    #[allow(clippy::too_many_arguments)]
     fn emit_cpu(
         &mut self,
         shard: u32,

core/src/stark/quotient.rs

@@ -17,7 +17,6 @@ use p3_util::log2_strict_usize;
 
 use super::StarkGenericConfig;
 
-#[allow(clippy::too_many_arguments)]
 pub fn quotient_values<SC, A, Mat>(
     chip: &Chip<Val<SC>, A>,
     cumulative_sum: SC::Challenge,

core/src/syscall/precompiles/blake3/compress/g.rs

@@ -179,6 +179,7 @@ impl<F: Field> GOperation<F> {
             }
         }
         // Degree 3 constraint to avoid "OodEvaluationMismatch".
+        #[allow(clippy::eq_op)]
         builder.assert_zero(is_real * is_real * is_real - is_real * is_real * is_real);
     }
 }

recursion/core/src/runtime/instruction.rs

@@ -26,7 +26,6 @@ pub struct Instruction<F> {
 }
 
 impl<F: PrimeField32> Instruction<F> {
-    #[allow(clippy::too_many_arguments)]
     pub fn new(
         opcode: Opcode,
         op_a: F,

recursion/program/src/constraints.rs

@@ -119,7 +119,6 @@ where
     }
 
     /// Reference: `[sp1_core::stark::Verifier::verify_constraints]`
-    #[allow(clippy::too_many_arguments)]
     pub fn verify_constraints<A>(
         builder: &mut Builder<C>,
         chip: &MachineChip<SC, A>,

recursion/program/src/fri/mod.rs

@@ -116,7 +116,6 @@ pub fn verify_challenges<C: Config>(
 /// Currently assumes the index that is accessed is constant.
 ///
 /// Reference: https://github.com/Plonky3/Plonky3/blob/4809fa7bedd9ba8f6f5d3267b1592618e3776c57/fri/src/verifier.rs#L101
-#[allow(clippy::too_many_arguments)]
 #[allow(unused_variables)]
 pub fn verify_query<C: Config>(
     builder: &mut Builder<C>,