Skip to content

Commit 8a39b95

Browse files
authored
fix: Don't use perf in plonk-artifacts workflow (#197)
Since the setup action will set both `SP1_DEV=true` and `FRI_QUERIES=1`, the plonk artifact generation fails. We can override `SP1_DEV` but cannot override `FRI_QUERIES` since different StarkMachines use different values. Unsetting variables set via `GITHUB_ENV` is not currently supported according to actions/runner#1126 So just pass `perf: false` instead
1 parent 8c1c1ef commit 8a39b95

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/plonk-artifacts.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
uses: ./.github/actions/setup
3434
with:
3535
pull_token: ${{ secrets.REPO_TOKEN }}
36+
perf: false
3637
- name: Install AWS CLI
3738
run: |
3839
sudo apt-get update
@@ -80,8 +81,6 @@ jobs:
8081
8182
echo "VERSION=$VERSION" | tee -a $GITHUB_ENV
8283
echo "needs-update=$NEEDS_UPDATE" | tee -a $GITHUB_OUTPUT
83-
# Disable `SP1_DEV` as it breaks artifact generation
84-
echo "SP1_DEV=false" | tee -a $GITHUB_ENV
8584
- name: Generate Plonk artifacts
8685
if: ${{ steps.check-s3.outputs.needs-update == 'true' }}
8786
run: |

0 commit comments

Comments
 (0)