Minor refactor changes

Author: arimger

Assets/Editor Toolbox/Editor/SceneView/ToolboxEditorSceneViewObjectSelector.cs

@@ -8,7 +8,6 @@ public class ToolboxEditorSceneViewObjectSelector : EditorWindow
     {
         private static readonly Color selectionColor = new Color(0.50f, 0.70f, 1.00f);
         private static readonly Color highlightWireColor = Color.yellow;
-        private const float outlineFillOpacity = 1f;
 
         private const float sizeXPadding = 2f;
         private const float sizeYPadding = 2f;
@@ -17,10 +16,10 @@ public class ToolboxEditorSceneViewObjectSelector : EditorWindow
         private const float sizeXOffset = -30f;
         private const float indentWidth = 12f;
 
-        private List<DisplayEntry> displayEntries;
+        private readonly List<Renderer> highlightedRenderers = new List<Renderer>();
 
+        private List<DisplayEntry> displayEntries;
         private GameObject highlightedObject;
-        private readonly List<Renderer> highlightedRenderers = new List<Renderer>();
         private Vector2 size;
         private Vector2 buttonSize;
 
@@ -42,12 +41,12 @@ public static void Show(List<GameObject> gameObjects, Vector2 position)
 
         private void OnEnable()
         {
-            UnityEditor.SceneView.duringSceneGui += OnSceneViewDuringSceneGui;
+            UnityEditor.SceneView.duringSceneGui += OnSceneViewGui;
         }
 
         private void OnDisable()
         {
-            UnityEditor.SceneView.duringSceneGui -= OnSceneViewDuringSceneGui;
+            UnityEditor.SceneView.duringSceneGui -= OnSceneViewGui;
             highlightedRenderers.Clear();
             highlightedObject = null;
         }
@@ -325,7 +324,10 @@ private void SelectObject(int id, bool control, bool shift)
             }
             else
             {
-                Selection.objects = new Object[] { gameObject };
+                Selection.objects = new Object[]
+                {
+                    gameObject
+                };
             }
         }
 
@@ -377,27 +379,6 @@ private void RemoveSelectedObject(GameObject gameObject)
             Selection.objects = newSelection;
         }
 
-        private GameObject HighlightedObject
-        {
-            set
-            {
-                if (highlightedObject == value)
-                {
-                    return;
-                }
-
-                highlightedObject = value;
-                UnityEditor.SceneView.RepaintAll();
-
-                if (highlightedObject != null)
-                {
-                    EditorGUIUtility.PingObject(highlightedObject);
-                }
-
-                UpdateHighlightedRenderers();
-            }
-        }
-
         private void UpdateHighlightedRenderers()
         {
             highlightedRenderers.Clear();
@@ -410,7 +391,7 @@ private void UpdateHighlightedRenderers()
             highlightedRenderers.AddRange(highlightedObject.GetComponentsInChildren<Renderer>(true));
         }
 
-        private void OnSceneViewDuringSceneGui(UnityEditor.SceneView sceneView)
+        private void OnSceneViewGui(UnityEditor.SceneView sceneView)
         {
             if (highlightedRenderers.Count == 0 ||
                 Event.current.type != EventType.Repaint)
@@ -438,6 +419,27 @@ private void OnSceneViewDuringSceneGui(UnityEditor.SceneView sceneView)
 #endif
         }
 
+        private GameObject HighlightedObject
+        {
+            set
+            {
+                if (highlightedObject == value)
+                {
+                    return;
+                }
+
+                highlightedObject = value;
+                UnityEditor.SceneView.RepaintAll();
+
+                if (highlightedObject != null)
+                {
+                    EditorGUIUtility.PingObject(highlightedObject);
+                }
+
+                UpdateHighlightedRenderers();
+            }
+        }
+
         private readonly struct DisplayEntry
         {
             internal DisplayEntry(GameObject gameObject, int depth)