Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect multi-page TIFF #259

Closed
finetjul opened this issue Aug 12, 2022 · 3 comments · Fixed by #283
Closed

Detect multi-page TIFF #259

finetjul opened this issue Aug 12, 2022 · 3 comments · Fixed by #283
Assignees

Comments

@finetjul
Copy link
Collaborator

See #229 + data linked here

@manthey
Copy link
Collaborator

manthey commented Sep 1, 2022

These files are being read by the tifffile tile source and are listing an axis of "I", which isn't one of Z, T, C, P (or XY).

@arjunrajlab
Copy link
Collaborator

Oh, I see. At least it is detecting an axis. Perhaps we just allow that axis to be specified by the user (default is Z).

@manthey
Copy link
Collaborator

manthey commented Sep 6, 2022

See girder/large_image#957.

Ultimately, we need to do something extra when a file doesn't have its internal frames labelled with an appropriate axes.

The sample files are read with the tifffile source and report that they have 6 frames, but there is no indication of the axes (e.g., are they T, Z, XY, etc). The referenced PR allows this to be specified in the multi source's yaml/json file. For a given source, you can add framesAsAxes: {<axis1>: <stride1>, <axis2>: <stride2>, ...}. For this case, for instance, this might be framesAsAxes: {z: 1} to indicate that the frames are the z axis.

We could do fancier things where an image with unlabelled axes contains two things (e.g., channel and z-stack), then that framesAsAxes would specify a stride for each of those axes.

@luciemac Once the associated large_image PR is merged, we'll need to add the appropriate frameAsAxes to the multi-source's file IF the source image doesn't have at least one of IndexC, IndexT, IndexZ, IndexXY.

@finetjul finetjul assigned ghost and unassigned luciemac Sep 23, 2022
@ghost ghost linked a pull request Sep 28, 2022 that will close this issue
@ghost ghost closed this as completed in #283 Sep 29, 2022
@bruyeret bruyeret self-assigned this Oct 12, 2022
@arjunrajlab arjunrajlab moved this to Done in Alpha Release May 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants