Potential bugs in collision detection

[SJ-Fang23]

Hi, the on_collision method doesn't seem to function properly.
It was giving

"spherov2/commands/sensor.py", line 117, in __collision_detected_notify_helper
unpacked = struct.unpack('>3hB3hBL', packet.data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
struct.error: unpack requires a buffer of 18 bytes

I changed it to ">3hB3hBh" and everything works again.

[SJ-Fang23]

I was using Sphero Bolt.

[XbzOnGit]

I met with the same problem and made the following modifications.

# 2 * (3 * 2 + 1) + 4 = 18.  
if(len(packet.data) < 18):
            packet = packet._replace(data=bytearray(18))

This also works.

[jswa9964]

Hey everyone, I had a bit of a puzzling issue with my on_collision event. It wasn't working and no errors were being thrown. I thought it might be something to do with my operating system (I’m on a Mac), but other window machines had the same problem.

What worked for me was using an older version of python.

I thought I’d add a link to my Issue since this thread was the first one I read to try and fix my issue.
Cheers

#45 (comment)