Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a release #12

Open
zamazan4ik opened this issue May 14, 2020 · 7 comments
Open

Create a release #12

zamazan4ik opened this issue May 14, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@zamazan4ik
Copy link

Hi! Thank you a lot for the awesome library!

Can you please make a release of the library? It'll help a lot with packaging your library in Conan since it's easier to choose proper package version with a release.

Thank you!

@arximboldi
Copy link
Owner

Thanks! Yeah I will try make a release for this and Lager soon :)

@BlueSolei
Copy link
Contributor

BlueSolei commented Jan 15, 2022

Hi,
I created a Conan package for the library.
Your code & talks are so cool :-)
For quite a while I want to start experiment with these ideas.
I started with building my dev-env, so here it is :-)
Question: do you consider this library to be production ready?
I really want to try integrate it in my new work.

@arximboldi
Copy link
Owner

Excellent! Thank you very much!

The library is depended on by Lager, which is used in production by a few of my clients. There are certain bits of Zug that are more battle tested than others. However in general the design is very simple it's rather low risk I'd think :)

@arximboldi
Copy link
Owner

arximboldi commented Jan 15, 2022

And sorry that I failed my promise of using proper versioning! I've been rather following master and keeping things stable there.

@BlueSolei
Copy link
Contributor

Conan-Index can work with projects which use their master continuously, they have some convention to it, I will check the details and implement them.
I have a failure in the build of a simple example on Windows as part of the Conan's CI test.
The error: zug/util.hpp(34): error C2496: 'zug::noop': 'selectany' can only be applied to data items with external linkage
The test file: example.cpp
Compiler: Visual Studio 2017
Do you know from the top of your head why does it fail?
I will try it on my Windows machine later this week, to see if I can figure it out.

@arximboldi arximboldi added the enhancement New feature or request label Jan 17, 2022
@arximboldi
Copy link
Owner

It seems to be related to this:

#define ZUG_INLINE_CONSTEXPR extern constexpr __declspec(selectany)
which I think was added by @CJBussey. Can you Carl shed some light on this? I am really not a MSVC expert.

@BlueSolei
Copy link
Contributor

I found the issue and fixed it.
I will update the CMakeLists.txt here for the windows users and will update the README with how to use the library with Conan once it will be merged to CCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants