-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a "zug_" prefix to target names and some other enhancements #26
Comments
Hmmm, if you use |
Also glad that you are finding the libraries useful or interesting!! ❤️ |
I'm using CMake's FetchContent module for dependencies. This is something I also picked up from the Javascript ecosystem. I don't like the |
I also discovered a bug on MSVC concerning inline constexpr variables and was able to fix it. MSVC doesn't allow constexpr variables being extern, so you have to pass in the compiler flag |
Yes it's the problem of FetchContent. You can instead have them as submodules in your git repo and just specify target_include_directories |
Hello!
I was trying to link zug and Boost.Hana in a project of mine and ran into issues with target names, so I decided to make a fork and add a
zug_
prefix to all targets, variables, and functions where one is missing and add a log function which adds a[zug::${PROJECT_NAME}]:
prefix to every status message from zug (when CCache has been or hasn't been found and when adding test targets).I ran the check target (its name is "zug_check" in my fork) and every test is passing.
I also noticed that when I include the sequence header I get an error saying boost::mpl is not present (there has been an issue discussing this, but I don't know if this was fixed), so I was thinking of adding a metafunction that does the same thing in the meta namespace.
Are you interested in a pull requests that do this? If not, I will just keep using my fork and merge from master from time to time to keep things updated, so it's not a problem on my part if you don't want this.
I would like to add a pull request that does this for immer as well if you are interested.
PS: I dig the idea of making C++ more functional and declarative coming from React, so thank you for all the great libraries 😄
The text was updated successfully, but these errors were encountered: