fix: correct handling of ASDF_FORCE_PREPEND environment variable (#2011)

Co-authored-by: Trevor Brown <[email protected]>

Author: machupicchubeta

internal/config/config.go

@@ -5,6 +5,8 @@ package config
 import (
 	"context"
 	"io/fs"
+	"os"
+	"runtime"
 	"strconv"
 	"strings"
 
@@ -39,7 +41,7 @@ type Config struct {
 	// Unclear if this value will be needed with the golang implementation.
 	// AsdfDir string
 	DataDir      string `env:"ASDF_DATA_DIR, overwrite"`
-	ForcePrepend bool   `env:"ASDF_FORCE_PREPEND, overwrite"`
+	ForcePrepend bool
 	// Field that stores the settings struct if it is loaded
 	Settings       Settings
 	PluginIndexURL string
@@ -59,8 +61,13 @@ type Settings struct {
 }
 
 func defaultConfig(dataDir, configFile string) *Config {
+	forcePrepend := forcePrependDefault
+	forcePrependEnv := os.Getenv("ASDF_FORCE_PREPEND")
+	if forcePrependEnv == "yes" || (forcePrependEnv == "" && runtime.GOOS == "darwin") {
+		forcePrepend = true
+	}
 	return &Config{
-		ForcePrepend:                forcePrependDefault,
+		ForcePrepend:                forcePrepend,
 		DataDir:                     dataDir,
 		ConfigFile:                  configFile,
 		DefaultToolVersionsFilename: defaultToolVersionsFilenameDefault,

internal/config/config_darwin_test.go

@@ -0,0 +1,17 @@
+//go:build darwin
+
+package config
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestLoadConfigEnv_WithForcePrependEnv_OnDarwin(t *testing.T) {
+	t.Run("When ASDF_FORCE_PREPEND env does not given on macOS", func(t *testing.T) {
+		config, _ := loadConfigEnv()
+
+		assert.True(t, config.ForcePrepend, "Then ForcePrepend property is true")
+	})
+}

internal/config/config_linux_test.go

@@ -0,0 +1,17 @@
+//go:build linux
+
+package config
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestLoadConfigEnv_WithForcePrependEnv_OnLinux(t *testing.T) {
+	t.Run("When ASDF_FORCE_PREPEND env does not given on Linux", func(t *testing.T) {
+		config, _ := loadConfigEnv()
+
+		assert.False(t, config.ForcePrepend, "Then ForcePrepend property is false")
+	})
+}

internal/config/config_test.go

@@ -22,6 +22,24 @@ func TestLoadConfigEnv(t *testing.T) {
 	assert.Zero(t, config.Home, "Shouldn't set Home property when loading config")
 }
 
+func TestLoadConfigEnv_WithForcePrependEnv(t *testing.T) {
+	t.Run("When ASDF_FORCE_PREPEND env given yes", func(t *testing.T) {
+		t.Setenv("ASDF_FORCE_PREPEND", "yes")
+
+		config, _ := loadConfigEnv()
+
+		assert.True(t, config.ForcePrepend, "Then ForcePrepend property is true")
+	})
+
+	t.Run("When ASDF_FORCE_PREPEND env given any string other than yes", func(t *testing.T) {
+		t.Setenv("ASDF_FORCE_PREPEND", "no")
+
+		config, _ := loadConfigEnv()
+
+		assert.False(t, config.ForcePrepend, "Then ForcePrepend property is false")
+	})
+}
+
 func TestLoadSettings(t *testing.T) {
 	t.Run("When given invalid path returns error", func(t *testing.T) {
 		settings, err := loadSettings("./foobar")