fix: set correct env vars on recursive calls (#1989)

Co-authored-by: Trevor Brown <[email protected]>

Author: andrecloutier

.editorconfig

@@ -8,6 +8,9 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
+[*.go]
+indent_style = tab
+
 [*.py]
 indent_size = 4
 

.gitignore

@@ -5,6 +5,7 @@ repository
 .vagrant
 keyrings
 /tmp
+.idea
 
 dist/
 

internal/cli/cli.go

@@ -342,7 +342,12 @@ func Execute(version string) {
 		},
 	}
 
-	if err := app.Run(os.Args); err != nil {
+	err := unsetAsdfReservedEnvVars()
+	if err != nil {
+		cli.OsExiter(1)
+	}
+
+	if err = app.Run(os.Args); err != nil {
 		cli.OsExiter(1)
 	}
 }
@@ -1567,3 +1572,16 @@ func installedStatus(installed bool) string {
 	}
 	return "missing"
 }
+
+func unsetAsdfReservedEnvVars() error {
+	// These are environment variables which are passed via env or exec.
+	// We strip these out to avoid any potential issues with recursive calls to asdf.
+	asdfManagedVars := []string{"ASDF_INSTALL_TYPE", "ASDF_INSTALL_VERSION", "ASDF_INSTALL_PATH"}
+	for _, v := range asdfManagedVars {
+		err := os.Unsetenv(v)
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}

test/plugin_extension_command.bats

@@ -116,3 +116,22 @@ EOF
   [ "$status" -eq 0 ]
   [ "$output" = "$expected" ]
 }
+
+@test "asdf execute plugin default command unsets ASDF_INSTALL_TYPE ASDF_INSTALL_VERSION and ASDF_INSTALL_PATH env variables" {
+  export ASDF_INSTALL_VERSION=1.2.3
+  export ASDF_INSTALL_TYPE=version
+  export ASDF_INSTALL_PATH=/somewhere
+
+  plugin_path="$(get_plugin_path dummy)"
+
+  # this plugin defines a new `asdf dummy` command
+  cat <<'EOF' >"$plugin_path/lib/commands/command"
+#!/usr/bin/env bash
+/usr/bin/env
+EOF
+  chmod +x "$plugin_path/lib/commands/command"
+
+  run asdf cmd dummy
+  [ "$status" -eq 0 ]
+  [ "0" -eq "$(echo "$output" | grep -c "ASDF_INSTALL_")" ]
+}