bug: install failed but it tell me already installed

[ziyouchutuwenwu]

Describe the Bug

run asdf install xxx, if it failed or manually interrupted, then run it again, it told me already installed.

Steps to Reproduce

1. install and interrupt it.

$ asdf install python 3.10.0
python-build 3.10.0 /home/mmc/.asdf/installs/python/3.10.0
Downloading Python-3.10.0.tar.xz...
-> https://registry.npmmirror.com/-/binary/python/3.10.0/Python-3.10.0.tar.xz
^C
error: failed to download Python-3.10.0.tar.xz

2. run it again

$ asdf install python 3.10.0
version 3.10.0 of python is already installed

Expected Behaviour

continue to install

Actual Behaviour

it told me already installed

Environment

$ asdf info                 
OS:
Linux manjaro 6.6.83-1-MANJARO #1 SMP PREEMPT_DYNAMIC Thu Mar 13 15:07:44 UTC 2025 x86_64 GNU/Linux

SHELL:
zsh 5.9 (x86_64-pc-linux-gnu)

BASH VERSION:
5.2.37(1)-release

ASDF VERSION:
v0.16.5

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/home/mmc/.asdf
ASDF_CONFIG_FILE=/home/mmc/.asdfrc

ASDF INSTALLED PLUGINS:
nodejs    https://github.com/asdf-vm/asdf-nodejs.git 5515b8705fbf4d610ede04bb9a3fc4812e3a4168
python    https://github.com/danhper/asdf-python.git a3a01856098d6d2b9642e382f5b38e70275726d1

asdf plugins affected (if relevant)

No response

[Stratus3D]

This should be fixed by #2024 which was released in version 0.16.6. Please upgrade and confirm that fixes this issue for you.

[ziyouchutuwenwu]

hi @Stratus3D , i use version 0.16.6 to try, it seems not to be solved, here are the steps

mmc at p53 in ~ (dev_env) 
$ asdf list python            
 *3.12.9

mmc at p53 in ~ (dev_env) 
$ asdf install python 3.10.0  
python-build 3.10.0 /home/mmc/.asdf/installs/python/3.10.0
Downloading Python-3.10.0.tar.xz...
-> https://registry.npmmirror.com/-/binary/python/3.10.0/Python-3.10.0.tar.xz
^C
error: failed to download Python-3.10.0.tar.xz                                        

mmc at p53 in ~ (dev_env) 
$ asdf install python 3.10.0
version 3.10.0 of python is already installed

mmc at p53 in ~ (dev_env) 
$ asdf list python          
  3.10.0
 *3.12.9

mmc at p53 in ~ (dev_env) 
$ asdf info                 
OS:
Linux p53 6.6.83-1-MANJARO #1 SMP PREEMPT_DYNAMIC Thu Mar 13 15:07:44 UTC 2025 x86_64 GNU/Linux

SHELL:
zsh 5.9 (x86_64-pc-linux-gnu)

BASH VERSION:
5.2.37(1)-release

ASDF VERSION:
v0.16.6

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/home/mmc/.asdf
ASDF_CONFIG_FILE=/home/mmc/.asdfrc

ASDF INSTALLED PLUGINS:
nodejs    https://github.com/asdf-vm/asdf-nodejs.git 93bd217ba74f05080eebb7d8e1c146a385b01d7f
python    https://github.com/danhper/asdf-python.git a3a01856098d6d2b9642e382f5b38e70275726d1

[Stratus3D]

I followed those steps and got different behavior. It will try to install Python on the second invocation of asdf install python 3.10.0.

[ziyouchutuwenwu]

hi @Stratus3D , I tried two methods.

One was to disconnect the network to simulate a failed download.

asdf install python 3.10.0

# dicsonnect to network, then run it again

asdf install python 3.10.0
# it will continue to download and install

another was pressing Ctrl+C when downloading python source to force an interruption, then i run it again, it reported as already installed.

asdf install python 3.10.0

press Ctrl+C when downloading starts

asdf install python 3.10.0
version 3.10.0 of python is already installed

[andrecloutier]

Ahh yes I can see ctrl-c (aka SIGINT) resulting in the install directory not getting cleaned up. There's a couple options here:

1. Modify ASDF to trap the signal and treat it like any other failure and cleanup the directory.
2. Modify ASDF to do the install in a temp location, and move it to the install directory only on success.

2 is the more certain way of making sure that only persist the install on success as this will also handle the SIGKILL case as well. But I suspect that isn't how the bash version worked and this may cause some surprise breakages for some plugins. I suspect option 1 is the way to go... I'd have to consult the bash code to see what it was up to.

Thoughts on the best path forward @Stratus3D ?

[Stratus3D]

@andrecloutier option 1 is best. A some tools actually get built with static paths so any changes to install dir would be problematic for those plugins. In the event that someone does SIGKILL and leaves an install dir they'll just have to manually run asdf uninstall ... to fix.

Alternatively perhaps we could define some sort of "success" file that gets written at the end of an install, so that when a directory lacks it we assume the install is broken and clean it up? Haven't given it much thought, something like this might be more hassle than it is worth.

[ZimbiX]

I think this issue should be reopened. I've faced this several times after using Ctrl+C to cancel an asdf ruby install during testing dev environment setup scripts. It occurs with rust too. I never noticed this with rbenv, which is also using ruby-build.

asdf info

➜ asdf info
OS:
Darwin M25017 24.4.0 Darwin Kernel Version 24.4.0: Wed Mar 19 21:17:35 PDT 2025; root:xnu-11417.101.15~1/RELEASE_ARM64_T6041 arm64

SHELL:
zsh 5.9 (arm64-apple-darwin24.0)

BASH VERSION:
3.2.57(1)-release

ASDF VERSION:
0.17.0 (revision unknown)

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/Users/brendan.weibrecht/.asdf
ASDF_CONFIG_FILE=/Users/brendan.weibrecht/.asdfrc

ASDF INSTALLED PLUGINS:
kubectl   https://github.com/asdf-community/asdf-kubectl.git
          2fb3b57090e3efe55953a751a134c271ba83b119
nodejs    https://github.com/asdf-vm/asdf-nodejs.git
          fd2c7f94c4c71416047cacf2af6e4fa819b364b7
ruby      https://github.com/asdf-vm/asdf-ruby.git
          3062b6c559206b955b2ff30a37f5a77c7757cd07
rust      https://github.com/code-lever/asdf-rust.git
          95acf4fe65df1de74fca502482b8f3ac5af73c05
yarn      https://github.com/twuni/asdf-yarn.git
          376c5407ef22c82fa56e4bd9f6a9108354063acb