Skip to content

Commit 398badb

Browse files
committed
fix(ci): build on Go 1.25 to clear GO-2026-4602 in govulncheck
The govulncheck CI job flagged GO-2026-4602 (FileInfo can escape from a Root in os), reachable via config.discoverRepos → filepath.WalkDir → os.ReadDir. It's fixed in the Go 1.25.8 standard library, but CI built with 1.24.13. - bump setup-go to "1.25" in ci.yml (build + security) and release.yml so the scan and released binaries use the patched stdlib - bump go.mod and README to Go 1.25
1 parent 8afd57d commit 398badb

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@v4
1313
- uses: actions/setup-go@v5
1414
with:
15-
go-version: "1.24"
15+
go-version: "1.25"
1616
- run: gofmt -l cmd internal | tee /dev/stderr | (! read)
1717
- run: go vet ./...
1818
- run: go build ./...
@@ -24,7 +24,7 @@ jobs:
2424
- uses: actions/checkout@v4
2525
- uses: actions/setup-go@v5
2626
with:
27-
go-version: "1.24"
27+
go-version: "1.25"
2828
# Scan dependencies and our own code for known Go vulnerabilities.
2929
- name: govulncheck
3030
run: |

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
- uses: actions/setup-go@v5
2222
with:
23-
go-version: "1.24"
23+
go-version: "1.25"
2424

2525
- name: Build cross-platform binaries
2626
run: make release

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ For a window you choose, it gathers **everything you did**:
2525

2626
## Install
2727

28-
### Option 1 — `go install` (needs Go 1.24+)
28+
### Option 1 — `go install` (needs Go 1.25+)
2929

3030
```bash
3131
go install github.com/ashishxcode/commit-chronicle/cmd/commit-chronicle@latest

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/ashishxcode/commit-chronicle
22

3-
go 1.24.2
3+
go 1.25.0
44

55
require (
66
github.com/charmbracelet/bubbles v1.0.0

0 commit comments

Comments
 (0)