Skip to content

Next release #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
16 of 17 tasks
Kijewski opened this issue Feb 4, 2025 · 17 comments
Closed
16 of 17 tasks

Next release #335

Kijewski opened this issue Feb 4, 2025 · 17 comments

Comments

@Kijewski
Copy link
Member

Kijewski commented Feb 4, 2025

Am I missing something? Is this the right order?

@GuillaumeGomez
Copy link
Collaborator

I'd prefer if instead we simply renamed the repository into askama. After all we're a fork, so we still have askama git history and that will make things simpler since we don't need to migrate issues and PRs.

Also, I need write a blog post about all this. :)

@Kijewski
Copy link
Member Author

Kijewski commented Feb 7, 2025

Well, I guess it does not matter a lot. I would have liked the other route better, though, regardless if it is more complicated.

@GuillaumeGomez
Copy link
Collaborator

Less work for us. :D

@Kijewski
Copy link
Member Author

Kijewski commented Feb 9, 2025

I don't think there is anything that we need to include the next release, esp. there are no breaking changes I would like to include. @GuillaumeGomez, is there something you would like to include or can we call it a "feature freeze". :)

@GuillaumeGomez
Copy link
Collaborator

Sorry didn't see this message. Yes, time for feature freeze!

@Kijewski
Copy link
Member Author

The project is https://github.com/askama-rs/askama/ again. 🎉

@GuillaumeGomez
Copy link
Collaborator

We should also update https://github.com/askama-rs/play-rinja repository.

@Kijewski
Copy link
Member Author

@GuillaumeGomez, first pre-release tomorrow? What do you think? :)

@GuillaumeGomez
Copy link
Collaborator

Sounds all good to me, thanks for the work! I really need to write the blog post. ^^'

@GuillaumeGomez
Copy link
Collaborator

Blog post is now written. :)

@Kijewski
Copy link
Member Author

@Kijewski
Copy link
Member Author

I tried to categorize all PRs between v0.3.5 and v0.13.0-pre.0: https://github.com/askama-rs/askama/releases/tag/v0.13.0-pre.0. The order is roughly by date. @GuillaumeGomez, if you would like to put PRs in other categories / change the categories / reorder some or all PRs, feel free. :)

DavidKorczynski pushed a commit to google/oss-fuzz that referenced this issue Mar 19, 2025
The original askama project was forked as rinja. Rinja implemented its
own fuzzer, and the current fuzzing configuration for the askama project
would not work for rinja. Rinja was renamed into askama, i.e. fork
became the main project, and the original project will get archived.

@GuillaumeGomez and I are the maintainers of the project.

Cf. <askama-rs/askama#335>
@GuillaumeGomez
Copy link
Collaborator

Wow, thanks for that! Looks all good to me. :)

@matze
Copy link

matze commented Mar 21, 2025

ask some people to try the pre-release

I tried. It was painless.

@Walter-Reactor
Copy link

Confirmed, I just tried uprevving diplomat from askama 0.12 & didn't find any changes I needed to make.

@Kijewski
Copy link
Member Author

I guess there is no need to release rinja v0.3.6 with a deprecation message. The version is not broken, and if someone does not want to update for some reason, they don't have to. Then, I guess we're all done here. What do you say, @GuillaumeGomez? :)

(Hopefully we never have such a big release again, though :D)

@GuillaumeGomez
Copy link
Collaborator

Nah I don't think it's necessary. Our work here is done. Congrats!

@Kijewski Kijewski unpinned this issue Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants