feat: enable RBE again (#406)

* feat: enable RBE again

It was disabled here
6749298#diff-c543330d148f738e9f3033a8afb70fec440c9328ae3d8f7b0019cc459b880c28L9

* chore: add comments

Author: alexeagle

.aspect/workflows/bazelrc

@@ -3,9 +3,17 @@ common --remote_download_outputs=minimal
 common --nobuild_runfile_links
 
 # remote execution
-common:rbe --extra_execution_platforms=//bazel/platforms:x86_64_linux_remote
-common:rbe --host_platform=//bazel/platforms:x86_64_linux_remote
+common:rbe --extra_execution_platforms=//tools/platforms:buildbarn_remote
+common:rbe --host_platform=//tools/platforms:buildbarn_remote
 common:rbe --remote_executor=unix:///mnt/ephemeral/buildbarn/.cache/bb_clientd/grpc
 common:rbe --genrule_strategy=remote,local
 common:rbe --jobs=32
 common:rbe --remote_timeout=3600
+
+# from https://github.com/bazelbuild/bazel/issues/4685#issuecomment-1366208392
+test:rbe --strategy=CoverageReport=local
+test:rbe --experimental_split_coverage_postprocessing
+test:rbe --experimental_fetch_all_coverage_outputs
+test:rbe --remote_download_outputs=all
+# from https://github.com/bazelbuild/bazel/issues/4685#issuecomment-1599671891
+test:rbe --experimental_remote_download_regex=.*/(coverage.dat$|_coverage/_coverage_report.dat$) 

.aspect/workflows/config.yaml

@@ -10,6 +10,7 @@ tasks:
         - -//speller/...
       bazel:
         flags:
+          -  --config=rbe
           -  --test_tag_filters=-skip-on-aspect-workflows
       coverage:
         codecov_upload: true

logger/client/src/build/aspect/BUILD.bazel

@@ -3,6 +3,8 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
 java_library(
     name = "JavaLoggingClientLibrary",
     srcs = ["JavaLoggingClientLibrary.java"],
+    # Workaround https://github.com/bazelbuild/bazel/issues/24838
+    tags = ["no-remote-exec"],
     deps = [
         "//logger/schema:logger_java_grpc",
         "//logger/schema:logger_java_proto",
@@ -14,6 +16,7 @@ java_library(
 java_binary(
     name = "JavaLoggingClient",
     srcs = ["JavaLoggingClient.java"],
+    tags = ["no-remote-exec"],  # see above
     visibility = ["//visibility:public"],
     deps = [":JavaLoggingClientLibrary"],
 )

logger/schema/BUILD.bazel

@@ -64,6 +64,8 @@ java_proto_library(
 java_library(
     name = "logger_java_grpc",
     srcs = ["LoggerGrpc.java"],
+    # Workaround https://github.com/bazelbuild/bazel/issues/24838
+    tags = ["no-remote-exec"],
     deps = [
         ":logger_java_proto",
         artifact("com.google.guava:guava"),

oci_go_image/BUILD.bazel

@@ -81,7 +81,10 @@ container_structure_test(
     configs = ["test.yaml"],
     # Use the image built for the target platform as it runs through docker
     image = ":transitioned_image",
-    tags = ["requires-docker"],
+    tags = [
+        "no-remote-exec",
+        "requires-docker",
+    ],
 )
 
 oci_push(

oci_python_image/hello_world/BUILD.bazel

@@ -92,7 +92,10 @@ container_structure_test(
     name = "test",
     configs = ["test.yaml"],
     image = ":platform_image",
-    tags = ["requires-docker"],
+    tags = [
+        "no-remote-exec",
+        "requires-docker",
+    ],
 )
 
 py_test(

bazel/platforms/BUILD.bazel renamed to tools/platforms/BUILD.bazel

@@ -1,12 +1,12 @@
 platform(
-    name = "x86_64_linux_remote",
+    name = "buildbarn_remote",
     constraint_values = [
         "@platforms//os:linux",
         "@platforms//cpu:x86_64",
     ],
     exec_properties = {
         "OSFamily": "Linux",
-        "container-image": "docker://ghcr.io/catthehacker/ubuntu:act-22.04@sha256:5f9c35c25db1d51a8ddaae5c0ba8d3c163c5e9a4a6cc97acd409ac7eae239448",
+        "container-image": "docker://public.ecr.aws/docker/library/python@sha256:247105bbbe7f7afc7c12ac893be65b5a32951c1d0276392dc2bf09861ba288a6",
     },
     visibility = ["//visibility:public"],
 )