Skip to content

[Bug]: *_update_snapshots target is generated when "snapshots" is set to False #224

Open
@fa93hws

Description

@fa93hws

What happened?

The doc says

snapshots: If True, a {name}_update_snapshots binary target is generated

However, from the source code, {name}_update_snapshots will be generated even if snapshots is False
https://github.com/aspect-build/rules_jest/blob/v0.19.6/jest/defs.bzl#L243-L263

Version

Development (host) and target OS/architectures:

Output of bazel --version: 6.4.0 Irrelevant to the issue though.

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 0.19.6

Language(s) and/or frameworks involved:

How to reproduce

No response

Any other information?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedAspect isn't prioritizing this, but the community could

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions