Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use xcopy on windows to support hidden files #427

Closed
wants to merge 1 commit into from
Closed

fix: use xcopy on windows to support hidden files #427

wants to merge 1 commit into from

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented May 10, 2023

Fix aspect-build/rules_js#1055

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • Added test case for hidden files but need manual testing on windows.

@jbedard jbedard mentioned this pull request May 10, 2023
Open
@jbedard jbedard marked this pull request as draft May 15, 2023 16:55
@jbedard
Copy link
Collaborator Author

jbedard commented May 16, 2023

I'm just going to add the tests for now: #438

@jbedard jbedard closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Js_run_binary copy srcs to bin fails on 'hidden' files on Windows
1 participant
@jbedard