Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: fs patches do not work on Windows #1137

Open
gregmagolan opened this issue Jul 3, 2023 · 0 comments
Open

[Bug]: fs patches do not work on Windows #1137

gregmagolan opened this issue Jul 3, 2023 · 0 comments
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could windows Specific to Windows

Comments

@gregmagolan
Copy link
Member

gregmagolan commented Jul 3, 2023 •
edited
Loading

fs patches do not currently work on Windows. When they are enabled they break transitive npm dep resolution in runfiles. There is no sandbox on Windows so the patches are less important.
@github-actions github-actions bot added the untriaged Requires traige label Jul 3, 2023
@gregmagolan gregmagolan mentioned this issue Jul 3, 2023
Merged
@gregmagolan gregmagolan added bug Something isn't working help wanted Aspect isn't prioritizing this, but the community could funding needed Contribute to https://opencollective.com/aspect-build windows Specific to Windows and removed untriaged Requires traige labels Jul 4, 2023
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could windows Specific to Windows
Projects
No open projects
Open Source
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregmagolan