Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messaging when using execpath and other make expansions #118

Open
alexeagle opened this issue May 23, 2022 · 0 comments
Open

Better error messaging when using execpath and other make expansions #118

alexeagle opened this issue May 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@alexeagle
Copy link
Member

#108 is an example of user error which is understandable, since rules_js sets the working directory differently from typical Bazel actions. We could:

  • detect use of $(execpath) etc. without ../ and warn ahead-of-time
  • same but only print after the action fails?
  • provide different expansion helpers?
  • modify behavior of them?
@cgrindel cgrindel added enhancement New feature or request prioritized labels Sep 27, 2022
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Open Source
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @cgrindel @gregmagolan