Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: 'include_npx' for js_binary #1213

Open
gregjacobs opened this issue Aug 14, 2023 · 0 comments
Open

[FR]: 'include_npx' for js_binary #1213

gregjacobs opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could

Comments

@gregjacobs
Copy link
Contributor

What is the current behavior?

There's currently an include_npm attribute for js_binary (https://github.com/aspect-build/rules_js/blob/main/docs/js_binary.md#js_binary-include_npm) to include the npm executable, which is great.

However, I'm using a package called icon-font-buildr which actually spawns npx at runtime. Currently I'm getting away with this because our CI machine has Node/npm/npx installed so I'm using the system path for it, but would ideally like to get this to work with RBE and systems that don't have Node already.

Describe the feature

Wondering if it would be possible to add an include_npx attribute for js_binary?

Or perhaps it would be better to just add a symlink for npx when include_npm is true? Thoughts?

@gregjacobs gregjacobs added the enhancement New feature or request label Aug 14, 2023
@github-actions github-actions bot added the untriaged Requires traige label Aug 14, 2023
@alexeagle alexeagle added help wanted Aspect isn't prioritizing this, but the community could funding needed Contribute to https://opencollective.com/aspect-build and removed untriaged Requires traige labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants