Unable to bazel run a js_binary() on Windows

[lukasoyen]

Trying to bazel run a binary created with js_binary() (using 86b7aaa) on Windows fails with the following error:

FATAL: aspect_rules_js[js_binary]: BAZEL_BINDIR must be set in environment to the makevar $(BINDIR) in js_binary build actions (which run in the execroot) so that build actions can change directories to always run out of the root of the Bazel output tree. See https://docs.bazel.build/versions/main/be/make-variables.html#predefined_variables. This is automatically set by 'js_run_binary' (https://github.com/aspect-build/rules_js/blob/main/docs/js_run_binary.md) which is the recommended rule to use for using a js_binary as the tool of a build action. If this is not a build action you can set the BAZEL_BINDIR to '.' instead to supress this error. For more context on this design decision, please read the aspect_rules_js README https://github.com/aspect-build/rules_js/tree/dbb5af0d2a9a2bb50e4cf4a96dbc582b27567155#running-nodejs-programs.

This bazel run is successfull on Linux/Mac. A js_run_binary() works.

I would guess the error is due to

rules_js/js/private/js_binary.sh.tpl

Line 250 in 86b7aaa

if [[ "$PWD" == *"/bazel-out/"* ]]; then

evaluating to false in that bazel run context. Adding a env = {"BAZEL_BINDIR":"$(BINDIR)"} to the js_binary() produces:

C:/users/XXX/XXX/hlezeung/execroot/XXX/bazel-out/x64_windows-opt/bin/XXX/dependencies/javascript/license_checker.sh: line 299: cd: bazel-out/x64_windows-opt/bin: No such file or directory

While looking at the code I thought JS_BINARY__BINDIR might be relevant here, but it seems unused except for the logging statement in

rules_js/js/private/js_binary.sh.tpl

Line 372 in 86b7aaa

logf_debug "binary target BINDIR %s" "${JS_BINARY__BINDIR:-}"