Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Make freeze logic on install more convenient to end users #847

Open
1 task
Aghassi opened this issue Feb 6, 2023 · 0 comments
Open
1 task

[FR]: Make freeze logic on install more convenient to end users #847

Aghassi opened this issue Feb 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Aghassi
Copy link
Collaborator

Aghassi commented Feb 6, 2023

What is the current behavior?

Currently, a user must export ASPECT_RULES_JS_FROZEN_PNPM_LOCK to enable update_pnpm_lock failures on CI for non frozen installs.

Describe the feature

Instead of having the users of this rule know a magic variable, just check for a common one like CI so that this works out of box without confusing the end user. A great package for simplifying this check is https://www.npmjs.com/package/env-ci which will do all the necessary checks for you.

Fund our work

@Aghassi Aghassi added the enhancement New feature or request label Feb 6, 2023
@gregmagolan gregmagolan moved this to 🔖 Ready in Open Source Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: On Deck
Development

No branches or pull requests

1 participant