Commit 5cda78b
committed
refactor: own the interpreter runtime toolchain rules instead of rules_python's
Generated interpreter repos now instantiate a rules_py py_runtime_toolchain
(py/private/interpreter/runtime.bzl, with a rules_py PyRuntimeInfo) instead of
rules_python's py_runtime + py_runtime_pair + py_exec_tools_toolchain. One
:runtime target per repo backs both toolchain registrations. Toolchain types
are unchanged (@bazel_tools python type; rules_python's exec_tools type, with
its exec_tools.exec_runtime/precompiler payload shape preserved), so
rules_python-provisioned interpreters still satisfy whl_install/site-merge and
rules_py still consumes user-registered rules_python py_runtime toolchains.
This shrinks each interpreter repo's rules_python loads from 31 .bzl files to
the 12 of the deliberately kept py_cc_toolchain chain, insulating provisioned
toolchains from rules_python implementation churn, and leaves the runtime
layer pinning no rules_python minimum version.
New coverage: e2e/rules-python-interop (isolated module) pins that a module
mixing both rulesets shares one rules_python-provisioned interpreter,
including a $(PYTHON3) location diff_test; e2e/cases/rules-python-consumers
pins that rules_python's own toolchain consumers (current_py_toolchain,
exec-tools readers) work against rules_py-backed toolchains.
Narrow breaks:
- Generated interpreter repo targets are renamed: @python_X//:py3_runtime,
:runtime_pair, and :exec_tools_toolchain are now a single @python_X//:runtime.
Only direct label references need updating; toolchain resolution is unaffected.
- rules_py-provisioned runtimes carry rules_py's PyRuntimeInfo, not
rules_python's. Provider-indexed access (target[PyRuntimeInfo] with
rules_python's symbol) on these targets or resolved toolchains breaks;
duck-typed field access keeps working. As a consequence, rules_python's
py_binary/py_test cannot execute on rules_py-provisioned toolchains (they
read provider fields rules_py does not carry) — the same one-way interop
direction #1231 establishes for PyInfo.
- The exec-tools toolchain rules_py registers provides precompiler = None;
enabling rules_python precompiling while @python_interpreters toolchains are
registered first is unsupported.1 parent f37599e commit 5cda78b
26 files changed
Lines changed: 406 additions & 132 deletions
File tree
- docs
- e2e
- cases
- rules-python-consumers
- uv-deps-650/crossbuild
- interpreter-runtime-metadata
- examples
- debugger
- dev_deps
- multi_version
- py
- private
- interpreter
- py_venv
- toolchain
- uv/private
- uv_hub/snapshots
- whl_install
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
277 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
278 | 293 | | |
279 | 294 | | |
280 | 295 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | | - | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | | - | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
12 | 17 | | |
13 | 18 | | |
14 | | - | |
15 | | - | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
21 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
22 | 30 | | |
23 | 31 | | |
24 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
1 | 4 | | |
2 | 5 | | |
3 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
0 commit comments