Skip to content

Commit cd0ff8a

Browse files
committed
feat: re-enable Java example of using pre-built protoc
1 parent 56b554d commit cd0ff8a

File tree

2 files changed

+13
-17
lines changed

2 files changed

+13
-17
lines changed

examples/BUILD.bazel

+4-7
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,10 @@ proto_library(
1717
# deps = [":foo_proto"],
1818
# )
1919

20-
# Broken by https://github.com/protocolbuffers/protobuf/pull/19679
21-
# which causes building C++ code from source.
22-
# TODO: re-enable once protobuf honors the toolchain
23-
# java_proto_library(
24-
# name = "foo_java_proto",
25-
# deps = [":foo_proto"],
26-
# )
20+
java_proto_library(
21+
name = "foo_java_proto",
22+
deps = [":foo_proto"],
23+
)
2724

2825
go_proto_library(
2926
name = "foo_go_proto",

examples/java/BUILD

+9-10
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
# See comment in examples/BUILD.bazel
2-
# java_binary(
3-
# name = "java",
4-
# srcs = ["Main.java"],
5-
# main_class = "Main",
6-
# deps = [
7-
# "//:foo_java_proto",
8-
# "@protobuf-java//jar",
9-
# ],
10-
# )
1+
java_binary(
2+
name = "java",
3+
srcs = ["Main.java"],
4+
main_class = "Main",
5+
deps = [
6+
"//:foo_java_proto",
7+
"@protobuf-java//jar",
8+
],
9+
)

0 commit comments

Comments
 (0)