Skip to content

rules_proto is deprecated, and it looks like that pre-build is not used if new official protobuf is used directly #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
develar opened this issue Feb 5, 2025 · 2 comments

Comments

@develar
Copy link

develar commented Feb 5, 2025

rules_proto is deprecated.
When protobuf is used, looks like that pre-built doesn't work and still I see C compilation.

@michaelschuett-tomtom
Copy link

Can you share an example reproducing case possibly in the example repo? This sounds like it is related to #41 in which case I opened an example PR here #48 you can try out.

@alexeagle
Copy link
Member

The examples folder in this repo is the proof of what works and what doesn't. With Bazel 8, go_proto_library is the only language rule I know of that correctly uses Bazel's toolchains feature to resolve the protoc binary. The ones in the protobuf repo are hard-coded to the cc_binary target and trigger compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants