Skip to content

Commit 9c7c871

Browse files
authored
Merge pull request #346 from faern/fix-minimal-versions-dependencies
Fix minimal versions dependencies
2 parents 20f47d2 + a3a20b9 commit 9c7c871

File tree

4 files changed

+25
-4
lines changed

4 files changed

+25
-4
lines changed

.github/workflows/ci.yml

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
permissions:
2424
contents: none
2525
name: CI
26-
needs: [test, msrv, lockfile, docs, rustfmt, clippy]
26+
needs: [test, msrv, lockfile, docs, rustfmt, clippy, minimal-versions]
2727
runs-on: ubuntu-latest
2828
if: "always()"
2929
steps:
@@ -72,6 +72,27 @@ jobs:
7272
run: cargo hack check --all-features --locked --rust-version --ignore-private --workspace --all-targets
7373
- name: No-default features
7474
run: cargo hack check --no-default-features --locked --rust-version --ignore-private --workspace --all-targets
75+
# Make sure the library builds with all dependencies downgraded to their
76+
# oldest versions allowed by the semver spec. This ensures we have not
77+
# under-specified any dependency
78+
minimal-versions:
79+
name: Minimal versions
80+
runs-on: ubuntu-latest
81+
steps:
82+
- name: Checkout repository
83+
uses: actions/checkout@v4
84+
- name: Install stable Rust
85+
uses: dtolnay/rust-toolchain@stable
86+
with:
87+
toolchain: stable
88+
- name: Install nightly Rust
89+
uses: dtolnay/rust-toolchain@stable
90+
with:
91+
toolchain: nightly
92+
- name: Downgrade dependencies to minimal versions
93+
run: cargo +nightly generate-lockfile -Z minimal-versions
94+
- name: Compile with minimal versions
95+
run: cargo +stable check --workspace --all-features --all-targets --locked
7596
lockfile:
7697
runs-on: ubuntu-latest
7798
steps:

crates/snapbox/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ content_inspector = { version = "0.2.4", optional = true }
7676
tempfile = { version = "3.0", optional = true }
7777
walkdir = { version = "2.3.2", optional = true }
7878
dunce = { version = "1.0", optional = true }
79-
filetime = { version = "0.2", optional = true }
79+
filetime = { version = "0.2.8", optional = true }
8080

8181
os_pipe = { version = "1.0", optional = true }
8282
wait-timeout = { version = "0.2.0", optional = true }

crates/trycmd/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ humantime-serde = "1"
6161
toml_edit = { version = "0.22.13", features = ["serde"] }
6262
escargot = { version = "0.5.7", optional = true }
6363

64-
schemars = { version = "0.8.3", features = ["preserve_order"], optional = true }
64+
schemars = { version = "0.8.9", features = ["preserve_order"], optional = true }
6565
serde_json = { version = "1.0", optional = true }
6666

6767
[lints]

crates/tryfn/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ color-auto = ["snapbox/color-auto"]
3737
[dependencies]
3838
snapbox = { path = "../snapbox", version = "0.6.10", default-features = false }
3939
libtest-mimic = "0.7.0"
40-
ignore = "0.4"
40+
ignore = "0.4.11"

0 commit comments

Comments
 (0)