Avoid repetition in the primary diagnostic message

Author: AlexWaygood

crates/ty_python_semantic/resources/mdtest/final.md

@@ -76,20 +76,31 @@ class Parent:
     def decorated_2(self): ...
 
 class Child(Parent):
-    def foo(self): ...  # error: [override-of-final-method]
+    # explicitly test the concise diagnostic message,
+    # which is different to the verbose diagnostic summary message:
+    #
+    # error: [override-of-final-method] "Cannot override final member `foo` from superclass `Parent`"
+    def foo(self): ...
     @property
     def my_property1(self) -> int: ...  # error: [override-of-final-method]
+
     @property
     def my_property2(self) -> int: ...  # error: [override-of-final-method]
+
     @classmethod
     def class_method1(cls) -> int: ...  # error: [override-of-final-method]
+
     @staticmethod
     def static_method1() -> int: ...  # error: [override-of-final-method]
+
     @classmethod
     def class_method2(cls) -> int: ...  # error: [override-of-final-method]
+
     @staticmethod
     def static_method2() -> int: ...  # error: [override-of-final-method]
+
     def decorated_1(self): ...  # TODO: should emit [override-of-final-method]
+
     @lossy_decorator
     def decorated_2(self): ...  # TODO: should emit [override-of-final-method]
 
@@ -181,6 +192,7 @@ class Good:
     def bar(self, x: str) -> str: ...
     @overload
     def bar(self, x: int) -> int: ...
+
     @final
     @overload
     def baz(self, x: str) -> str: ...
@@ -192,6 +204,7 @@ class ChildOfGood(Good):
     def bar(self, x: str) -> str: ...
     @overload
     def bar(self, x: int) -> int: ...  # error: [override-of-final-method]
+
     @overload
     def baz(self, x: str) -> str: ...
     @overload
@@ -204,6 +217,7 @@ class Bad:
     @final
     # error: [invalid-overload]
     def bar(self, x: int) -> int: ...
+
     @overload
     def baz(self, x: str) -> str: ...
     @final
@@ -216,6 +230,7 @@ class ChildOfBad(Bad):
     def bar(self, x: str) -> str: ...
     @overload
     def bar(self, x: int) -> int: ...  # error: [override-of-final-method]
+    
     @overload
     def baz(self, x: str) -> str: ...
     @overload

crates/ty_python_semantic/resources/mdtest/snapshots/final.md_-_Tests_for_the_`@typi…_-_A_possibly-undefined…_(fc7b496fd1986deb).snap

@@ -75,7 +75,7 @@ error[override-of-final-method]: Cannot override `A.method1`
    |
 34 | class B(A):
 35 |     def method1(self) -> None: ...  # error: [override-of-final-method]
-   |         ^^^^^^^ Override of `method1` from superclass `A`
+   |         ^^^^^^^ Overrides a definition from superclass `A`
 36 |     def method2(self) -> None: ...  # error: [override-of-final-method]
 37 |     def method3(self) -> None: ...  # error: [override-of-final-method]
    |
@@ -112,7 +112,7 @@ error[override-of-final-method]: Cannot override `A.method2`
 34 | class B(A):
 35 |     def method1(self) -> None: ...  # error: [override-of-final-method]
 36 |     def method2(self) -> None: ...  # error: [override-of-final-method]
-   |         ^^^^^^^ Override of `method2` from superclass `A`
+   |         ^^^^^^^ Overrides a definition from superclass `A`
 37 |     def method3(self) -> None: ...  # error: [override-of-final-method]
 38 |     def method4(self) -> None: ...  # error: [override-of-final-method]
    |
@@ -149,7 +149,7 @@ error[override-of-final-method]: Cannot override `A.method3`
 35 |     def method1(self) -> None: ...  # error: [override-of-final-method]
 36 |     def method2(self) -> None: ...  # error: [override-of-final-method]
 37 |     def method3(self) -> None: ...  # error: [override-of-final-method]
-   |         ^^^^^^^ Override of `method3` from superclass `A`
+   |         ^^^^^^^ Overrides a definition from superclass `A`
 38 |     def method4(self) -> None: ...  # error: [override-of-final-method]
    |
 info: `A.method3` is decorated with `@final`, forbidding overrides
@@ -184,7 +184,7 @@ error[override-of-final-method]: Cannot override `A.method4`
 36 |     def method2(self) -> None: ...  # error: [override-of-final-method]
 37 |     def method3(self) -> None: ...  # error: [override-of-final-method]
 38 |     def method4(self) -> None: ...  # error: [override-of-final-method]
-   |         ^^^^^^^ Override of `method4` from superclass `A`
+   |         ^^^^^^^ Overrides a definition from superclass `A`
 39 |
 40 | # Possible overrides of possibly `@final` methods...
    |
@@ -221,7 +221,7 @@ error[override-of-final-method]: Cannot override `A.method1`
 44 |         # statements inside the `if:` branch
 45 |         # (but it might still be a useful autofix in an IDE context?)
 46 |         def method1(self) -> None: ...  # error: [override-of-final-method]
-   |             ^^^^^^^ Override of `method1` from superclass `A`
+   |             ^^^^^^^ Overrides a definition from superclass `A`
 47 |     else:
 48 |         pass
    |
@@ -257,7 +257,7 @@ error[override-of-final-method]: Cannot override `A.method2`
    |
 50 |     if coinflip():
 51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-   |             ^^^^^^^ Override of `method2` from superclass `A`
+   |             ^^^^^^^ Overrides a definition from superclass `A`
 52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
 53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
    |
@@ -293,7 +293,7 @@ error[override-of-final-method]: Cannot override `A.method3`
 50 |     if coinflip():
 51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
 52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
-   |             ^^^^^^^ Override of `method3` from superclass `A`
+   |             ^^^^^^^ Overrides a definition from superclass `A`
 53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
    |
 info: `A.method3` is decorated with `@final`, forbidding overrides
@@ -326,7 +326,7 @@ error[override-of-final-method]: Cannot override `A.method4`
 51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
 52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
 53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
-   |             ^^^^^^^ Override of `method4` from superclass `A`
+   |             ^^^^^^^ Overrides a definition from superclass `A`
    |
 info: `A.method4` is decorated with `@final`, forbidding overrides
   --> src/mdtest_snippet.py:29:9