Skip to content

Commit 56cd2aa

Browse files
committed
try to optimize
1 parent 70ca5d1 commit 56cd2aa

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

crates/ty_python_semantic/src/types/liskov.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ fn check_class_declaration<'db>(
4949
return;
5050
};
5151

52-
let (literal, specialization) = class.class_literal(db);
53-
let class_kind = CodeGeneratorKind::from_class(db, literal, specialization);
54-
5552
let Place::Defined(type_on_subclass_instance, _, _) =
5653
Type::instance(db, class).member(db, &member.name).place
5754
else {
5855
return;
5956
};
6057

58+
let (literal, specialization) = class.class_literal(db);
59+
let class_kind = CodeGeneratorKind::from_class(db, literal, specialization);
60+
6161
let mut subclass_overrides_superclass_declaration = false;
6262
let mut has_dynamic_superclass = false;
6363
let mut has_typeddict_in_mro = false;
@@ -176,14 +176,12 @@ fn check_class_declaration<'db>(
176176
continue;
177177
}
178178

179-
let Some(superclass_type_as_callable) = superclass_type
180-
.try_upcast_to_callable(db)
181-
.map(|callables| callables.into_type(db))
182-
else {
179+
let Some(superclass_type_as_callable) = superclass_type.try_upcast_to_callable(db) else {
183180
continue;
184181
};
185182

186-
if type_on_subclass_instance.is_assignable_to(db, superclass_type_as_callable) {
183+
if type_on_subclass_instance.is_assignable_to(db, superclass_type_as_callable.into_type(db))
184+
{
187185
continue;
188186
}
189187

0 commit comments

Comments
 (0)