test: skip a samp tests on macos

These particular test seems to hang forever on the MacOS CI runner,
likely due to some race condition or other.

Author: fjebaker

pyvo/samp/tests/test_client.py

@@ -1,5 +1,6 @@
 # Licensed under a 3-clause BSD style license - see LICENSE.rst
 
+import sys
 import pytest
 
 # By default, tests should not use the internet.
@@ -9,23 +10,28 @@
 from pyvo.samp.hub_proxy import SAMPHubProxy
 from pyvo.samp.integrated_client import SAMPIntegratedClient
 
+IS_MACOS = sys.platform == "darwin"
+
 
 def setup_module(module):
     conf.use_internet = False
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 def test_SAMPHubProxy():
     """Test that SAMPHubProxy can be instantiated"""
     SAMPHubProxy()
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 @pytest.mark.slow
 def test_SAMPClient():
     """Test that SAMPClient can be instantiated"""
     proxy = SAMPHubProxy()
     SAMPClient(proxy)
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 def test_SAMPIntegratedClient():
     """Test that SAMPIntegratedClient can be instantiated"""
     SAMPIntegratedClient()
@@ -40,6 +46,7 @@ def samp_hub():
     my_hub.stop()
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 @pytest.mark.filterwarnings("ignore:unclosed <socket:ResourceWarning")
 def test_SAMPIntegratedClient_notify_all(samp_hub):
     """Test that SAMP returns a warning if no receiver got the message."""
@@ -51,6 +58,7 @@ def test_SAMPIntegratedClient_notify_all(samp_hub):
     client.disconnect()
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 def test_reconnect(samp_hub):
     """Test that SAMPIntegratedClient can reconnect.
     This is a regression test for bug [#2673]

pyvo/samp/tests/test_hub.py

@@ -1,22 +1,27 @@
 # Licensed under a 3-clause BSD style license - see LICENSE.rst
 
 import time
+import sys
 
 import pytest
 
 from pyvo.samp import conf
 from pyvo.samp.hub import SAMPHubServer
 
+IS_MACOS = sys.platform == "darwin"
+
 
 def setup_module(module):
     conf.use_internet = False
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 def test_SAMPHubServer():
     """Test that SAMPHub can be instantiated"""
     SAMPHubServer(web_profile=False, mode="multiple", pool_size=1)
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 @pytest.mark.slow
 def test_SAMPHubServer_run():
     """Test that SAMPHub can be run"""
@@ -26,6 +31,7 @@ def test_SAMPHubServer_run():
     hub.stop()
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 @pytest.mark.slow
 def test_SAMPHubServer_run_repeated():
     """

pyvo/samp/tests/test_hub_proxy.py

@@ -1,12 +1,18 @@
+import sys
+import pytest
+
 from pyvo.samp import conf
 from pyvo.samp.hub import SAMPHubServer
 from pyvo.samp.hub_proxy import SAMPHubProxy
 
+IS_MACOS = sys.platform == "darwin"
+
 
 def setup_module(module):
     conf.use_internet = False
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 class TestHubProxy:
     def setup_method(self, method):
         self.hub = SAMPHubServer(web_profile=False, mode="multiple", pool_size=1)

pyvo/samp/tests/test_standard_profile.py

@@ -1,4 +1,5 @@
 import os
+import sys
 import pytest
 
 # By default, tests should not use the internet.
@@ -11,12 +12,14 @@
 from .test_helpers import TEST_REPLY, Receiver, assert_output, random_params
 
 CI = os.environ.get("CI", "false") == "true"
+IS_MACOS = sys.platform == "darwin"
 
 
 def setup_module(module):
     conf.use_internet = False
 
 
+@pytest.mark.skipif(IS_MACOS, reason="This test hangs on MacOS.")
 @pytest.mark.skipif(CI, reason="flaky in CI")
 class TestStandardProfile:
     @property