CI: MacOS SAMP tests hang indefinitely

[fjebaker]

See the discussion in #729.

I am not sure which particular SAMP tests are triggering the hang at the moment, but I suspect the root cause is a race condition in one of the client + server tests, as much of it relies on time.sleep calls to wait for services to come up.

Also I notice that the MacOS test is running indefinitely on main now too, so it's one of those partially reproducible bugs too:

https://github.com/astropy/pyvo/actions/runs/22249692754/job/64370734717

[pllim]

This is not a problem in astropy but the test setup there is also a bit different. I see that pyvo uses --reruns. 🤷‍♀️

[bsipocz]

reruns never caused any such issues either here or in astroquery or locally on osx. So, it's still a puzzle and I wonder that it may be instead related to other tests we run.

And it looks like we haven't disabled enough of the tests in the PR, the cron job keeps hanging right now.

[bsipocz]

OK, so the issue is that somehow tests that should be skipped in CI are still running and thus failing; they are skipped as expected in the astropy test suite:

.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/tests/test_standard_profile.py F [ 95%]
                                                                         [ 95%]
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/tests/test_web_profile.py F [ 95%]
.                                                                        [ 95%]
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/utils/tests/test_http.py . [ 96%]
                                                                         [ 96%]

[bsipocz]

As I see most of the issues are around starting the samp hub, currently a couple of tests error out around the lines like these

        my_hub = SAMPHubServer()
        my_hub.start()

[bsipocz]

OTOH, this may really be just a bad combination of CI and maybe an upstream bug in pytest-remotedata.

One full traceback is here for the record:

    def samp_hub():
        """A fixture that can be used by client tests that require a HUB."""
        my_hub = SAMPHubServer()
>       my_hub.start()

.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/tests/test_client.py:38: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/hub.py:418: in start
    self._start_web_profile_server()
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/hub.py:288: in _start_web_profile_server
    self._web_profile_server = WebProfileXMLRPCServer(
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/web_profile.py:140: in __init__
    ThreadingXMLRPCServer.__init__(
.tox/py312-test-alldeps/lib/python3.12/site-packages/pyvo/samp/standard_profile.py:149: in __init__
    SimpleXMLRPCServer.__init__(
/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/xmlrpc/server.py:594: in __init__
    socketserver.TCPServer.__init__(self, addr, requestHandler, bind_and_activate)
/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/socketserver.py:457: in __init__
    self.server_bind()
/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/socketserver.py:478: in server_bind
    self.socket.bind(self.server_address)
.tox/py312-test-alldeps/lib/python3.12/site-packages/pytest_remotedata/disable_internet.py:85: in new_function
    fqdn = socket.getfqdn()
           ^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

name = 'sat12-dp154-45227d84-e638-4f66-93c8-aaf75b05ebc8-EE2AC6E7DFBD.local'

    def getfqdn(name=''):
        """Get fully qualified domain name from name.
    
        An empty argument is interpreted as meaning the local host.
    
        First the hostname returned by gethostbyaddr() is checked, then
        possibly existing aliases. In case no FQDN is available and `name`
        was given, it is returned unchanged. If `name` was empty, '0.0.0.0' or '::',
        hostname from gethostname() is returned.
        """
        name = name.strip()
        if not name or name in ('0.0.0.0', '::'):
            name = gethostname()
        try:
>           hostname, aliases, ipaddrs = gethostbyaddr(name)
                                         ^^^^^^^^^^^^^^^^^^^
E           Failed: Timeout (>30.0s) from pytest-timeout.

/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/socket.py:808: Failed