-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add prettier to the code base #331
Comments
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
relevant |
wouldnt it be better to do this with a precommit (husky) ? should i raise the pr? cc @ashmit-coder |
That's sounds like a good idea as well but my experience with husky has not been the greatest yet. |
What's your opinion @AceTheCreator |
hmm, can you elaborate a bit 🤔 about it?, i have been using it in some of my big projects in my org and it works without any trouble |
the problem is that husky commits the prettier changes and then to make any new changes you have to pull from your own repo again and again. |
Still seems a great idea to me go ahead and proceed with the pr. |
Why do we need this improvement?
To make the code have better formatting and maintainable in the long run.
How will this change help?
It will make formatting of files easier and bring rules to it.
Screenshots
No response
How could it be implemented/designed?
At first adding prettier with all the formattings then the Github Action associated with it.
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
No someone else can.
The text was updated successfully, but these errors were encountered: