Exceptions are lost in DeadlineContextDecorator

[Prunkles]

Description

protoactor-dotnet/src/Proto.Actor/Context/DeadlineContextDecorator.cs

Lines 50 to 57 in 173ee91

	public override async Task Receive(MessageEnvelope envelope)
	{
	var receiveTask = base.Receive(envelope);
	if (receiveTask.IsCompleted)
	{
	return;
	}

If the task returned by base.Receive(envelope) throws an exception synchronously (i.e. immediately, not awaiting anything, e.g. Task.FromException(ex)), then the code above just ignores the exception and returns.

Expected Behavior

The exception should be propagated up to the call stack.

[Prunkles]

What it means in practice is that system props are configured with the DeadlineContextDecorator by default:

protoactor-dotnet/src/Proto.Actor/ActorSystemConfig.cs

Line 79 in 173ee91

.WithLoggingContextDecorator(logger, LogLevel.None, LogLevel.Debug)

So if I spawn a system actor that will throw an exception synchronously on receiving, this exception will be ignored, so it won't even be handled in the mailbox and so on

[rogeralsing]

@codex research this,
especially:

So if I spawn a system actor that will throw an exception synchronously on receiving, this exception will be ignored, so it won't even be handled in the mailbox and so on

[chatgpt-codex-connector]

Summary

• Ensured synchronous Receive failures in DeadlineContextDecorator are awaited so exceptions propagate instead of being ignored. src/Proto.Actor/Context/DeadlineContextDecorator.csL50-L71
• Added a system-actor regression test that validates synchronous exceptions trigger restarts under the deadline decorator path. tests/Proto.Actor.Tests/DeadlineContextDecoratorTests.csL1-L30
• Documented the referenced synchronous exception scenario in the exception log. logs/exceptions.mdL73-L74

Testing

• ⚠️ dotnet test tests/Proto.Actor.Tests/Proto.Actor.Tests.csproj (command not found: dotnet)
• ⚠️ dotnet test tests/Proto.Remote.Tests/Proto.Remote.Tests.csproj (command not found: dotnet)
• ⚠️ dotnet test tests/Proto.Cluster.Tests/Proto.Cluster.Tests.csproj (command not found: dotnet)

View task →

[Prunkles]

And I'm not sure, but maybe the same issue exists in StartupDeadlineContextDecorator. I haven't faced with this there, but the code looks very similar. Maybe there are even more places like this