Skip to content

Commit 1d1bf93

Browse files
authored
Merge pull request #829 from atlanhq/revert-820-fix/dynamo-db-attribute-parent-qn-validation
Revert "fix(assets): validate parent_qualified_name in DynamoDBAttribute creator"
2 parents e262f45 + 6932cb1 commit 1d1bf93

2 files changed

Lines changed: 1 addition & 22 deletions

File tree

pyatlan/model/assets/dynamo_d_b_attribute.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1914,9 +1914,6 @@ def creator(
19141914
["name", "parent_qualified_name", "order"],
19151915
[name, parent_qualified_name, order],
19161916
)
1917-
fields = parent_qualified_name.split("/")
1918-
if len(fields) != 4:
1919-
raise ValueError("Invalid parent_qualified_name")
19201917
if connection_qualified_name:
19211918
connector_name = AtlanConnectorType.get_connector_name(
19221919
connection_qualified_name
@@ -1928,6 +1925,7 @@ def creator(
19281925
if order < 0:
19291926
raise ValueError("Order must be be a positive integer")
19301927

1928+
fields = parent_qualified_name.split("/")
19311929
qualified_name = f"{parent_qualified_name}/{name}"
19321930
connection_qualified_name = connection_qualified_name or connection_qn
19331931
table_name = parent_name or fields[3]

tests/unit/model/dynamo_db_attribute_test.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -108,25 +108,6 @@ def test_creator_with_explicit_connection_qualified_name():
108108
assert sut.order == 0
109109

110110

111-
@pytest.mark.parametrize(
112-
"parent_qualified_name",
113-
[
114-
DYNAMODB_CONNECTION_QUALIFIED_NAME,
115-
DYNAMODB_ATTRIBUTE_QUALIFIED_NAME,
116-
],
117-
)
118-
def test_creator_with_connection_qn_and_invalid_parent_raises_value_error(
119-
parent_qualified_name,
120-
):
121-
with pytest.raises(ValueError, match="Invalid parent_qualified_name"):
122-
DynamoDBAttribute.creator(
123-
name=DYNAMODB_ATTRIBUTE_NAME,
124-
parent_qualified_name=parent_qualified_name,
125-
order=1,
126-
connection_qualified_name=DYNAMODB_CONNECTION_QUALIFIED_NAME,
127-
)
128-
129-
130111
@pytest.mark.parametrize(
131112
"qualified_name, name, message",
132113
[

0 commit comments

Comments
 (0)