Add Atlaspack V3 config and integration tests for new transformers #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration tests
🦋 Changeset detectedLatest commit: 171e77c The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Missing ChangesetNo changeset found in PR. |
Contributor
Rust Package Changeset Check
Options:
Example: |
Contributor
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
Contributor
📊 Benchmark Results📊 Benchmark ResultsOverall Performance
🔍 Detailed Phase AnalysisThree.js Real Repository (JS)
Three.js Real Repository (V3)
💾 Unified Memory AnalysisThree.js Real Repository (JS) Memory Statistics
Sample Counts: JS: 14, Native: 303 Three.js Real Repository (V3) Memory Statistics
Sample Counts: JS: 14, Native: 468 🖥️ Environment
|
at-nathan
reviewed
Dec 3, 2025
| .get(&Atom::from("NATIVE_SSR_TYPEOF_REPLACEMENT")) | ||
| .is_some_and(|v| v == "true"); | ||
| let global_aliasing_config = match env_vars.get(&Atom::from("NATIVE_GLOBAL_ALIASING")) { | ||
| Some(value) => match serde_json::from_str::<HashMap<String, String>>(value) { |
Contributor
There was a problem hiding this comment.
Do we want to cache this value so it's not parsed on every file?
Contributor
Author
There was a problem hiding this comment.
I think it's probably not worth the effort and extra maintenance given the efficiency of Serde and the miniscule scale of the configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My recent transformers lacked Atlaspack V3 config parsing or any integration tests (just unit tests), this little followup remedies that.
Changes
Checklist
docs/folder