Store editor in ivar

Author: kevinsawicki

Diff for: lib/diff-list-view.coffee

@@ -13,29 +13,26 @@ class DiffListView extends SelectListView
 
   viewForItem: ({oldStart, newStart, oldLines, newLines}) ->
     bufferRow = if newStart > 0 then newStart - 1 else newStart
+    lineText = @editor.lineForBufferRow(bufferRow) ? ''
     $$ ->
       @li class: 'two-lines', =>
-        @div atom.workspace.getActiveEditor()?.lineForBufferRow(bufferRow), class: 'primary-line'
+        @div lineText, class: 'primary-line'
         @div "-#{oldStart},#{oldLines} +#{newStart},#{newLines}", class: 'secondary-line'
 
   populate: ->
-    if editor = atom.workspace.getActiveEditor()
-      diffs = atom.project.getRepo()?.getLineDiffs(editor.getPath(), editor.getText()) ? []
-      @setItems(diffs)
+    diffs = atom.project.getRepo()?.getLineDiffs(@editor.getPath(), @editor.getText()) ? []
+    @setItems(diffs)
 
   toggle: ->
     if @hasParent()
       @cancel()
-    else
+    else if @editor = atom.workspace.getActiveEditor()
       @populate()
       @attach()
 
   confirmed: ({newStart})->
     @cancel()
 
-    editorView = atom.workspaceView.getActiveView()
-    if editor = editorView?.getEditor?()
-      bufferRow = if newStart > 0 then newStart - 1 else newStart
-      editorView.scrollToBufferPosition([bufferRow, 0], center: true)
-      editor.setCursorBufferPosition([bufferRow, 0])
-      editor.moveCursorToFirstCharacterOfLine()
+    bufferRow = if newStart > 0 then newStart - 1 else newStart
+    @editor.setCursorBufferPosition([bufferRow, 0], autoscroll: true)
+    @editor.moveCursorToFirstCharacterOfLine()