From c09a46b31ee0b9d070895daee73c7e8698108fb9 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Wed, 2 Dec 2020 20:06:02 -0600 Subject: [PATCH 1/3] Add clang-tidy --- .clang-tidy | 4 ++++ package.json | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .clang-tidy diff --git a/.clang-tidy b/.clang-tidy new file mode 100644 index 00000000..2e8fb22b --- /dev/null +++ b/.clang-tidy @@ -0,0 +1,4 @@ +--- +Checks: "*, -clang-diagnostic-*-compat, -cppcoreguidelines-init-variables, -modernize-return-braced-init-list, -misc-unused-parameters, -misc-non-private-member-variables-in-classes, -llvmlibc-*, -llvm-header-guard, -llvm-include-order, -modernize-use-trailing-return-type, -readability-avoid-const-params-in-decls, -readability-convert-member-functions-to-static, -fuchsia-default-arguments-declarations, -fuchsia-default-arguments-calls, -*-uppercase-literal-suffix, -fuchsia-overloaded-operator, -google-build-using-namespace, -google-global-names-in-headers, -google-readability-todo, -*-else-after-return, -*-braces-around-statements" +HeaderFilterRegex: ".*" +FormatStyle: none diff --git a/package.json b/package.json index 9ea8aa1b..021eb572 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,9 @@ "test": "npm run test:node && npm run test:browser", "benchmark": "node benchmark/marker-index.benchmark.js", "prepublishOnly": "git submodule update --init --recursive && npm run build:browser", - "standard": "standard --recursive src test" + "standard": "standard --recursive src test", + "tidy": "clang-tidy src/core/*.cc src/core/*.h src/bindings/*.cc src/bindings/*.h src/bindings/em/*.cc src/bindings/em/*.h", + "tidy:fix": "npm run tidy -- --fix --fix-errors" }, "repository": { "type": "git", From 7613c5fafe6359c4adf29c41621ceed791659d31 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Wed, 2 Dec 2020 20:09:26 -0600 Subject: [PATCH 2/3] Add clang-format script --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 021eb572..de5cb78e 100644 --- a/package.json +++ b/package.json @@ -15,6 +15,7 @@ "benchmark": "node benchmark/marker-index.benchmark.js", "prepublishOnly": "git submodule update --init --recursive && npm run build:browser", "standard": "standard --recursive src test", + "format": "clang-format -i src/core/*.cc src/core/*.h src/bindings/*.cc src/bindings/*.h src/bindings/em/*.cc src/bindings/em/*.h", "tidy": "clang-tidy src/core/*.cc src/core/*.h src/bindings/*.cc src/bindings/*.h src/bindings/em/*.cc src/bindings/em/*.h", "tidy:fix": "npm run tidy -- --fix --fix-errors" }, From bf648ccdbf15065a4b79ef69c76a343be55c0f77 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Thu, 3 Dec 2020 05:49:35 -0600 Subject: [PATCH 3/3] Exclude reserved identifiers from clang-tidy The codebase uses variables that are called `_edit`, `_ses`, etc. We should fix these later --- .clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 2e8fb22b..ae1f79b7 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,4 +1,4 @@ --- -Checks: "*, -clang-diagnostic-*-compat, -cppcoreguidelines-init-variables, -modernize-return-braced-init-list, -misc-unused-parameters, -misc-non-private-member-variables-in-classes, -llvmlibc-*, -llvm-header-guard, -llvm-include-order, -modernize-use-trailing-return-type, -readability-avoid-const-params-in-decls, -readability-convert-member-functions-to-static, -fuchsia-default-arguments-declarations, -fuchsia-default-arguments-calls, -*-uppercase-literal-suffix, -fuchsia-overloaded-operator, -google-build-using-namespace, -google-global-names-in-headers, -google-readability-todo, -*-else-after-return, -*-braces-around-statements" +Checks: "*, -clang-diagnostic-*-compat, -cppcoreguidelines-init-variables, -modernize-return-braced-init-list, -misc-unused-parameters, -misc-non-private-member-variables-in-classes, -llvmlibc-*, -llvm-header-guard, -llvm-include-order, -modernize-use-trailing-return-type, -readability-avoid-const-params-in-decls, -readability-convert-member-functions-to-static, -fuchsia-default-arguments-declarations, -fuchsia-default-arguments-calls, -*-uppercase-literal-suffix, -fuchsia-overloaded-operator, -google-build-using-namespace, -google-global-names-in-headers, -google-readability-todo, -*-else-after-return, -*-braces-around-statements, -bugprone-reserved-identifier, -cert-dcl37-c, -cert-dcl51-cpp" HeaderFilterRegex: ".*" FormatStyle: none