Duplicating file doesn't preserve executable bit

[alexjurkiewicz]

Description

When using "duplicate" action on a file in tree view, the new file doesn't have the executable bit set even if the source file did.

Versions

OSX 10.12

$ atom --version
Atom    : 1.21.2
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
$ apm --version
apm  1.18.5
npm  3.10.10
node 6.9.5 x64
python 2.7.10
git 2.15.1

[rsese]

Thanks for the report - I can reproduce with Atom 1.23.3 on macOS 10.12.6, tentatively tagging as a bug for now.

[H8to]

The issue affects also all other permissions e.g. read write for group and others.
Any way to contribute to a solution on this issue?

[rsese]

Thanks for your interest @H8to! As with other confirmed issues, the team would review a well-written pull request from the community. With their current workload, they would not be able to prioritize investigating the issue themselves however.

[H8to]

I assume it may have to do with the usage of fs.copySync in /usr/lib/atom/node_modules/tree-view/lib/tree-view.js

But that function should preserve file permissions. I try to get some help on this.

Edit:
I gave my best to get an understanding of what happens during the copy-job but phew..
As pentester I do not have deep understanding of programming coffee-script, js or similar.

if (initialPathIsDirectory) {
              results.push(catchAndShowFileErrors((function(_this) {
                return function() {
                  fs.copySync(initialPath, newPath);
                  return _this.emitter.emit('entry-copied', {
                    initialPath: initialPath,
                    newPath: newPath
                  });
                };
              })(this)));

from /usr/lib/atom/node_modules/tree-view/lib/tree-view.js

Atom seems to use the fs.copySync function which should preserve the permissions as per the changelogs of node-fs-extra:

0.11.1 / 2014-09-02
-------------------
- bugfix `copySync()` preserve file permissions [#80][#80]

However this is not the case. Maybe @jprichardson might have an idea as he wrote fs.copySync.

Regards